KVM: x86: x2APIC reserved bits/regs fixes
Status from this message: Applied to kvm-x86 apic, thanks past me!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | KVM: x86: Inject #GP if WRMSR sets reserved bits in APIC Self-IPIarch/ | +7 | 1 reply | |
| 2/6 | KVM: x86: Inject #GP on x2APIC WRMSR that sets reserved bits 63:32arch/ | +5 | 1 reply | |
| 3/6 | KVM: x86: Mark x2APIC DFR reg as non-existent for x2APICarch/ | +4 | 1 reply | |
| 4/6 | KVM: x86: Split out logic to generate "readable" APIC regs mask to helperarch/ arch/ | +23 | 1 reply | |
| 5/6 | KVM: VMX: Always intercept accesses to unsupported "extended" x2APIC regsarch/ | +20 | 3 replies | |
| 6/6 | KVM: VMX: Intercept reads to invalid and write-only x2APIC registersarch/ | +4 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Maxim Levitsky | Jim Mattson |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] KVM: x86: x2APIC reserved bits/regs fixes
Fixes for edge cases where KVM mishandles reserved bits/regs checks when the vCPU is in x2APIC mode.
The first two patches were previously posted[*], but both patches were broken (as posted against upstream), hence I took full credit for doing the work and changed Marc to a reporter.
The VMX APICv fixes are for bugs found when writing tests. *sigh* I didn't Cc those to stable as the odds of breaking something when touching the MSR bitmaps seemed higher than someone caring about a 10 year old bug.
AMD x2AVIC support may or may not suffer similar interception bugs, but I don't have hardware to test and this already snowballed further than expected...
[*] https://lore.kernel.org/kvm/[email protected]
Sean Christopherson (6):
KVM: x86: Inject #GP if WRMSR sets reserved bits in APIC Self-IPI
KVM: x86: Inject #GP on x2APIC WRMSR that sets reserved bits 63:32
KVM: x86: Mark x2APIC DFR reg as non-existent for x2APIC
KVM: x86: Split out logic to generate "readable" APIC regs mask to
helper
KVM: VMX: Always intercept accesses to unsupported "extended" x2APIC
regs
KVM: VMX: Intercept reads to invalid and write-only x2APIC registers
arch/x86/kvm/lapic.c | 55 ++++++++++++++++++++++++++---------------- arch/x86/kvm/lapic.h | 2 ++ arch/x86/kvm/vmx/vmx.c | 40 +++++++++++++++--------------- 3 files changed, 57 insertions(+), 40 deletions(-)
base-commit: 91dc252b0dbb6879e4067f614df1e397fec532a1
Signature · 1 line
2.39.0.314.g84b9a713c41-goog