devlink: linecard and reporters locking cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest12 patches 12 repliesIn review 11 of 12 applied
- v410 patches 3 repliesSuperseded
- v311 patches 11 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 9 patches | 9 replies | Superseded | |
| v1 | 8 patches | 1 reply | Superseded |
Changes in v5 from the cover letter
- fixed mlx5 locking issues
Patches in v5 11 of 12 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | devlink: remove linecards lockdrivers/ include/ net/ +2 more | +21 | 1 reply | |
| 2/12 | devlink: remove linecard reference countingnet/ net/ net/ | +2 | 1 reply | Applied |
| 3/12 | net/mlx5e: Create separate devlink instance for ethernet auxiliary devicedrivers/ drivers/ drivers/ +1 more | +55 | 1 reply | Applied |
| 4/12 | net/mlx5: Remove MLX5E_LOCKED_FLOW flagdrivers/ include/ | +2 | 1 reply | Applied |
| 5/12 | devlink: protect health reporter operation with instance lockdrivers/ drivers/ include/ +1 more | +110 | 1 reply | Applied |
| 6/12 | devlink: remove reporters_lockinclude/ net/ net/ +1 more | +9 | 1 reply | Applied |
| 7/12 | devlink: remove devl*_port_health_reporter_destroy()drivers/ drivers/ include/ +1 more | +4 | 1 reply | Applied |
| 8/12 | devlink: remove reporter reference countingnet/ | +30 | 1 reply | Applied |
| 9/12 | devlink: convert linecards dump to devlink_nl_instance_iter_dump()net/ net/ net/ | +30 | 1 reply | Applied |
| 10/12 | devlink: convert reporters dump to devlink_nl_instance_iter_dump()net/ net/ net/ | +40 | 1 reply | Applied |
| 11/12 | devlink: remove devlink_dump_for_each_instance_get() helpernet/ net/ | +4 | 1 reply | Applied |
| 12/12 | devlink: add instance lock assertion in devl_is_registered()net/ | +1 | 1 reply | Applied |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Ido Schimmel | Jacob Keller |
|---|---|---|
| 1/12 | R-b | R-b |
| 2/12 | R-b | R-b |
| 3/12 | R-b | |
| 4/12 | R-b | |
| 5/12 | R-b | |
| 6/12 | R-b | |
| 7/12 | R-b | |
| 8/12 | R-b | |
| 9/12 | R-b | R-b |
| 10/12 | R-b | |
| 11/12 | R-b | |
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch net-next v5 00/12] devlink: linecard and reporters locking cleanup
From: Jiri Pirko <[email protected]>
This patchset does not change functionality.
Patches 1-2 remove linecards lock and reference counting, converting them to be protected by devlink instance lock as the rest of the objects.
Patches 3-4 fix the mlx5 auxiliary device devlink locking scheme whis is needed for proper reporters lock conversion done in the following patches.
Patches 5-8 remove reporters locks and reference counting, converting them to be protected by devlink instance lock as the rest of the objects.
Patches 9 and 10 convert linecards and reporters dumpit callbacks to recently introduced devlink_nl_instance_iter_dump() infra.
Patch 11 removes no longer needed devlink_dump_for_each_instance_get() helper.
The last patch adds assertion to devl_is_registered() as dependency on other locks is removed.
---v4->v5:
- fixed mlx5 locking issuesv3->v4:
- patch #1 was removed from the set and will be sent as a part of another patchsetv2->v3:
- see individual patches for changelog, mainly original patch #4 was split into 3 patches for easier reviewv1->v2:
- patch 7 bits were unsquashed to patch 8
Jiri Pirko (12):
devlink: remove linecards lock
devlink: remove linecard reference counting
net/mlx5e: Create separate devlink instance for ethernet auxiliary
device
net/mlx5: Remove MLX5E_LOCKED_FLOW flag
devlink: protect health reporter operation with instance lock
devlink: remove reporters_lock
devlink: remove devl*_port_health_reporter_destroy()
devlink: remove reporter reference counting
devlink: convert linecards dump to devlink_nl_instance_iter_dump()
devlink: convert reporters dump to devlink_nl_instance_iter_dump()
devlink: remove devlink_dump_for_each_instance_get() helper
devlink: add instance lock assertion in devl_is_registered()
drivers/net/ethernet/mellanox/mlx5/core/dev.c | 14 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 + .../ethernet/mellanox/mlx5/core/en/devlink.c | 44 +- .../ethernet/mellanox/mlx5/core/en/devlink.h | 5 +- .../mellanox/mlx5/core/en/reporter_rx.c | 2 +- .../mellanox/mlx5/core/en/reporter_tx.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 25 +- drivers/net/ethernet/mellanox/mlxsw/core.c | 8 +- .../ethernet/mellanox/mlxsw/core_linecards.c | 8 +- drivers/net/netdevsim/health.c | 20 +- include/linux/mlx5/driver.h | 4 - include/net/devlink.h | 27 +- net/devlink/core.c | 4 - net/devlink/devl_internal.h | 20 +- net/devlink/leftover.c | 442 +++++++----------- net/devlink/netlink.c | 12 +- 16 files changed, 272 insertions(+), 369 deletions(-)
Signature · 1 line
2.39.0