Skip to content

Add Auxiliary driver support

Ajit Khaparde linux-rdma lkml netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 3 repliesIn review

v1->v2 from the cover letter

- Incorporated review comments including usage of ulp_id & complex function indirections.
- Used function calls provided by the auxiliary bus interface instead of proprietary calls.
- Refactor code to remove ROCE driver's access to bnxt structure.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8bnxt_en: Add auxiliary driver supportdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+177 -312 replies
2/8RDMA/bnxt_re: Use auxiliary driver interfacedrivers/infiniband/hw/bnxt_re/bnxt_re.h drivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+132 -3040 replies
3/8bnxt_en: Remove usage of ulp_iddrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+115 -1520 replies
4/8bnxt_en: Use direct API instead of indirectiondrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+45 -1290 replies
5/8bnxt_en: Use auxiliary bus calls over proprietary callsdrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h+87 -570 replies
6/8bnxt_en: Remove struct bnxt access from RoCE driverdrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h+27 -150 replies
7/8RDMA/bnxt_re: Remove the sriov config callbackdrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+8 -400 replies
8/8bnxt_en: Remove runtime interrupt vector allocationdrivers/infiniband/hw/bnxt_re/bnxt_re.h drivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+45 -1370 replies

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy GospodarekSelvin XavierLeon Romanovsky
SeriesR-b
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] Add Auxiliary driver support

Ajit Khaparde <[email protected]>
Dec 7, 2022, 9:53 AM
to me, andrew.gospodarek, davem, edumazet, jgg, kuba, leon, linux-kernel, linux-rdma, michael.chan, netdev, pabeni, selvin.xavier

Add auxiliary device driver for Broadcom devices. The bnxt_en driver will register and initialize an aux device if RDMA is enabled in the underlying device.
The bnxt_re driver will then probe and initialize the RoCE interfaces with the infiniband stack.

We got rid of the bnxt_en_ops which the bnxt_re driver used to communicate with bnxt_en.
Similarly We have tried to clean up most of the bnxt_ulp_ops. In most of the cases we used the functions and entry points provided by the auxiliary bus driver framework.
And now these are the minimal functions needed to support the functionality.

We will try to work on getting rid of the remaining if we find any other viable option in future.

v1->v2:
- Incorporated review comments including usage of ulp_id & complex function indirections.
- Used function calls provided by the auxiliary bus interface instead of proprietary calls.
- Refactor code to remove ROCE driver's access to bnxt structure.

v2->v3:
- Addressed review comments including cleanup of some unnecessary wrappers
- Fixed warnings seen during cross compilation

v3->v4:
- Cleaned up bnxt_ulp.c and bnxt_ulp.h further
- Removed some more dead code
- Sending the patchset as a standalone series

v4->v5:
- Removed the SRIOV config callback which bnxt_en driver was calling into bnxt_re driver.
- Removed excessive checks for rdev and other pointers.

v5->v6:
- Removed excessive checks for dev and other pointers
- Remove runtime interrupt vector allocation. bnxt_en preallocates interrupt vectors for bnxt_re to use.

Please apply. Thanks.

Ajit Khaparde (7):
bnxt_en: Add auxiliary driver support RDMA/bnxt_re: Use auxiliary driver interface
bnxt_en: Remove usage of ulp_id
bnxt_en: Use direct API instead of indirection
bnxt_en: Use auxiliary bus calls over proprietary calls RDMA/bnxt_re: Remove the sriov config callback
bnxt_en: Remove runtime interrupt vector allocation

Hongguang Gao (1):
bnxt_en: Remove struct bnxt access from RoCE driver

 drivers/infiniband/hw/bnxt_re/bnxt_re.h       |  10 +-
 drivers/infiniband/hw/bnxt_re/main.c          | 635 +++++++-----------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  11 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |   8 +
 .../net/ethernet/broadcom/bnxt/bnxt_sriov.c   |   7 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 489 ++++++--------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |  57 +-
 7 files changed, 494 insertions(+), 723 deletions(-)
Signature · 1 line
2.37.1 (Apple Git-137.1)