Skip to content

Remove toolchain dependencies for Zicbom

Conor Dooley linux-riscv 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3RISC-V: insn-def: Add I-type insn-defarch/riscv/include/asm/insn-def.h+46 -00 repliesApplied
2/3RISC-V: replace cbom instructions with an insn-defarch/riscv/include/asm/errata_list.h arch/riscv/include/asm/insn-def.h+14 -10 repliesApplied
3/3RISC-V: remove toolchain version checks for Zicbomarch/riscv/Kconfig arch/riscv/Makefile+0 -110 repliesApplied

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchConor DooleyHeiko StuebnerAndrew Jones
SeriesR-b
1/3R-b R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/3] Remove toolchain dependencies for Zicbom

From: Conor Dooley <[email protected]>

Hey all,

I've yoinked patch 1 from Drew's series adding support for Zicboz & attached two more patches here that remove the need for, and then drop the toolchain support checks for Zicbom. The goal is to remove the need for checking the presence of toolchain Zicbom support in the work being done to support non instruction based CMOs [1].

I've tested compliation on a number of different configurations with the Zicbom config option enabled. The important ones to call out I guess are:
- clang/llvm 14 w/ LLVM=1 which doesn't support Zicbom atm.
- gcc 11 w/ binutils 2.37 which doesn't support Zicbom atm either.
- clang/llvm 15 w/ LLVM=1 BUT with binutils 2.37's ld. This is the configuration that prompted adding the LD checks as cc/as supports Zicbom, but ld doesn't [2].
- gcc 12 w/ binutils 2.39 & clang 15 w/ LLVM=1, both of these supported Zicbom before and still do.

I also checked building the THEAD errata etc with CONFIG_RISCV_ISA_ZICBOM disabled, and there were no build issues there either.

Drew - I took the liberty of dropping the cbo.zero addition from your patch.

Thanks,
Conor.

1 - https://lore.kernel.org/linux-riscv/[email protected]/
2 - https://lore.kernel.org/linux-riscv/[email protected]/

CC Arnd Bergmann <[email protected]>
CC Conor Dooley <[email protected]>
CC Geert Uytterhoeven <[email protected]>
CC Heiko Stuebner <[email protected]>
CC Guo Ren <[email protected]>
CC Andrew Jones <[email protected]>
CC Palmer Dabbelt <[email protected]>
CC Lad Prabhakar <[email protected]>

Andrew Jones (1):
RISC-V: insn-def: Add I-type insn-def

Conor Dooley (2):
RISC-V: replace cbom instructions with an insn-def
RISC-V: remove toolchain version checks for Zicbom

 arch/riscv/Kconfig                   |  8 ----
 arch/riscv/Makefile                  |  3 --
 arch/riscv/include/asm/errata_list.h |  3 +-
 arch/riscv/include/asm/insn-def.h    | 58 ++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+), 12 deletions(-)
Signature · 7 lines
2.39.0


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv