Skip to content

hw/i2c/bitbang_i2c: Housekeeping

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-trivial 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v25 patches 1 replySuperseded
  3. v15 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Use array of const pointers to const (Richard)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public headerhw/arm/musicpal.c hw/i2c/bitbang_i2c.c include/hw/i2c/bitbang_i2c.h+4 -20 replies
2/5hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegionhw/i2c/bitbang_i2c.c+2 -50 replies
3/5hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() helperhw/i2c/bitbang_i2c.c+15 -80 replies
4/5hw/i2c/bitbang_i2c: Trace state changeshw/i2c/bitbang_i2c.c hw/i2c/trace-events+31 -50 replies
5/5hw/i2c/bitbang_i2c: Convert DPRINTF() to trace eventshw/i2c/bitbang_i2c.c hw/i2c/trace-events+10 -120 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard HendersonCorey Minyard
SeriesA-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping

Series fully reviewed.

Since v2:
- Use array of const pointers to const (Richard)

Since v1:
- Fixed overwritten RECEIVING_BIT7 entry (Richard)
- Picked R-b tags

- Remove unused dummy MemoryRegion
- Convert DPRINTF() to using trace events

(series used as base for follow-up, better if merged via ARM tree)

Philippe Mathieu-Daudé (5):
hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state()
helper
hw/i2c/bitbang_i2c: Trace state changes hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events

 hw/arm/musicpal.c            |  3 +-
 hw/i2c/bitbang_i2c.c         | 80 ++++++++++++++++++++++--------------
 hw/i2c/trace-events          |  7 ++++
 include/hw/i2c/bitbang_i2c.h |  2 +
 4 files changed, 61 insertions(+), 31 deletions(-)
Signature · 1 line
2.38.1