Skip to content

hw: Convert simple devices from SysBus to QDev

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/arm/musicpal: Remove unused dummy MemoryRegionhw/arm/musicpal.c+0 -41 reply
2/9qdev: Add qdev_create_simple() helperhw/core/qdev.c include/hw/qdev-core.h+20 -00 replies
3/9hw/i2c/bitbang_i2c: Convert TYPE_GPIO_I2C from SysBus to QDevhw/arm/musicpal.c hw/i2c/bitbang_i2c.c+3 -40 replies
4/9hw/arm/tosa: Convert TYPE_TOSA_MISC_GPIO from SysBus to QDevhw/arm/tosa.c+2 -70 replies
5/9hw/arm/palm: Convert TYPE_PALM_MISC_GPIO from SysBus to QDevhw/arm/palm.c+2 -70 replies
6/9hw/arm/musicpal: Convert TYPE_MUSICPAL_KEY from SysBus to QDevhw/arm/musicpal.c+3 -30 replies
7/9hw/arm/spitz: Convert TYPE_SPITZ_KEYBOARD from SysBus to QDevhw/arm/spitz.c+5 -30 replies
8/9hw/arm/tosa: Convert TYPE_SPITZ_MISC_GPIO from SysBus to QDevhw/arm/spitz.c+7 -30 replies
9/9hw/i386/kvm: Convert TYPE_KVM_CLOCK from SysBus to QDevhw/i386/kvm/clock.c+3 -30 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchRichard Henderson
1/9R-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] hw: Convert simple devices from SysBus to QDev

Various simple devices (usually GPIO related) don't access the 'system bus': no IRQ lines / memory regions exposed via the SysBus API, no memory region mapped.

To reduce complexity, remove the sysbus onion layer from these devices.

Introduce the qdev_create_simple() helper similar to the pattern used for other device creation helpers:

 $ git grep _create_simple include/
 include/hw/i2c/i2c.h:175:I2CSlave *i2c_slave_create_simple(I2CBus *bus, const char *name, uint8_t addr);
 include/hw/isa/isa.h:86:ISADevice *isa_create_simple(ISABus *bus, const char *name);
 include/hw/misc/led.h:93:LEDState *led_create_simple(Object *parentobj,
 include/hw/pci/pci.h:735:PCIDevice *pci_create_simple_multifunction(PCIBus *bus, int devfn,
 include/hw/pci/pci.h:738:PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name);
 include/hw/sysbus.h:100:static inline DeviceState *sysbus_create_simple(const char *name,
 include/hw/usb.h:505:USBDevice *usb_create_simple(USBBus *bus, const char *name);

Based-on: <[email protected]>
"hw/i2c/bitbang_i2c: Housekeeping"

Philippe Mathieu-Daudé (9):
hw/arm/musicpal: Remove unused dummy MemoryRegion
qdev: Add qdev_create_simple() helper hw/i2c/bitbang_i2c: Convert TYPE_GPIO_I2C from SysBus to QDev hw/arm/tosa: Convert TYPE_TOSA_MISC_GPIO from SysBus to QDev hw/arm/palm: Convert TYPE_PALM_MISC_GPIO from SysBus to QDev hw/arm/musicpal: Convert TYPE_MUSICPAL_KEY from SysBus to QDev hw/arm/spitz: Convert TYPE_SPITZ_KEYBOARD from SysBus to QDev hw/arm/tosa: Convert TYPE_SPITZ_MISC_GPIO from SysBus to QDev hw/i386/kvm: Convert TYPE_KVM_CLOCK from SysBus to QDev

 hw/arm/musicpal.c      | 12 ++++--------
 hw/arm/palm.c          |  9 ++-------
 hw/arm/spitz.c         | 18 ++++++++++++------
 hw/arm/tosa.c          |  9 ++-------
 hw/core/qdev.c         |  9 +++++++++
 hw/i2c/bitbang_i2c.c   |  5 ++---
 hw/i386/kvm/clock.c    |  6 +++---
 include/hw/qdev-core.h | 11 +++++++++++
 8 files changed, 45 insertions(+), 34 deletions(-)
Signature · 1 line
2.38.1