Skip to content

drm: Do not include <linux/fb.h> unnecessarily

Thomas Zimmermann amd-gfx dri-devel linux-arm-kernel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 12 repliesIn review
  2. v15 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* add more patches to handle drm_fb_helper.h includes
* fix komeda build (kernel test robot)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm: Include <linux/backlight.h> where neededdrivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/gma500/backlight.c +1 more+5 -22 replies
2/10drm: Include <linux/of.h> where neededdrivers/gpu/drm/arm/display/komeda/komeda_drv.c drivers/gpu/drm/drm_modes.c drivers/gpu/drm/panel/panel-ronbo-rb070d30.c+5 -24 replies
3/10drm: Don't include <linux/fb.h> in drm_crtc_helper.hinclude/drm/drm_crtc_helper.h+0 -21 reply
4/10drm/amdgpu: Do not include <linux/fb.h>drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +6 more+0 -90 replies
5/10drm/panel: Do not include <linux/fb.h>drivers/gpu/drm/panel/panel-ilitek-ili9881c.c drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c drivers/gpu/drm/panel/panel-ronbo-rb070d30.c+0 -31 reply
6/10drm: Define enum mode_set_atomic in drm_modeset_helper_tables.hinclude/drm/drm_fb_helper.h include/drm/drm_modeset_helper_vtables.h+5 -61 reply
7/10drm/amdgpu: Do not include <drm/drm_fb_helper.h>drivers/gpu/drm/amd/amdgpu/dce_v10_0.c drivers/gpu/drm/amd/amdgpu/dce_v11_0.c drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +1 more+0 -42 replies
8/10drm/nouveau: Do not include <drm/drm_fb_helper.h>drivers/gpu/drm/nouveau/dispnv04/crtc.c drivers/gpu/drm/nouveau/nouveau_drm.c+0 -20 replies
9/10drm/radeon: Remove trailing whitespacesdrivers/gpu/drm/radeon/radeon_legacy_crtc.c+1 -10 replies
10/10drm/radeon: Do not include <drm/drm_fb_helper.h>drivers/gpu/drm/radeon/atombios_crtc.c drivers/gpu/drm/radeon/radeon_connectors.c drivers/gpu/drm/radeon/radeon_drv.c +1 more+0 -40 replies

Reviews trailers per patch

6 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian KönigVille SyrjäläSam Ravnborg
SeriesA-b
1/10A-b R-b
2/10
3/10R-b
4/10A-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] drm: Do not include <linux/fb.h> unnecessarily

Remove unnecessary include statements for <linux/fb.h>. I recently changed this header and had to rebuild a good part of DRM. So avoid this by removing the dependency.

Several files include <linux/fb.h> via drm_fb_helper.h. So in v2 I added additional patches that remove some of those include statements as well.

Some source files require the OF or backlight headers. Include those instead.

v2:
* add more patches to handle drm_fb_helper.h includes
* fix komeda build (kernel test robot)

Thomas Zimmermann (10):
drm: Include <linux/backlight.h> where needed
drm: Include <linux/of.h> where needed
drm: Don't include <linux/fb.h> in drm_crtc_helper.h drm/amdgpu: Do not include <linux/fb.h>
drm/panel: Do not include <linux/fb.h>
drm: Define enum mode_set_atomic in drm_modeset_helper_tables.h drm/amdgpu: Do not include <drm/drm_fb_helper.h> drm/nouveau: Do not include <drm/drm_fb_helper.h> drm/radeon: Remove trailing whitespaces
drm/radeon: Do not include <drm/drm_fb_helper.h>

 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c                    | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c                     | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c                      | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c                      | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c                       | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c                       | 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c           | 1 +
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c         | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c         | 1 -
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c             | 1 +
 drivers/gpu/drm/drm_modes.c                                 | 5 +++--
 drivers/gpu/drm/gma500/backlight.c                          | 2 ++
 drivers/gpu/drm/nouveau/dispnv04/crtc.c                     | 1 -
 drivers/gpu/drm/nouveau/nouveau_drm.c                       | 1 -
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c               | 1 -
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c       | 1 -
 drivers/gpu/drm/panel/panel-ronbo-rb070d30.c                | 2 +-
 drivers/gpu/drm/radeon/atombios_crtc.c                      | 1 -
 drivers/gpu/drm/radeon/radeon_acpi.c                        | 2 +-
 drivers/gpu/drm/radeon/radeon_connectors.c                  | 1 -
 drivers/gpu/drm/radeon/radeon_drv.c                         | 1 -
 drivers/gpu/drm/radeon/radeon_legacy_crtc.c                 | 3 +--
 include/drm/drm_crtc_helper.h                               | 2 --
 include/drm/drm_fb_helper.h                                 | 5 -----
 include/drm/drm_modeset_helper_vtables.h                    | 6 +++++-
 31 files changed, 16 insertions(+), 35 deletions(-)

base-commit: ac04152253dccfb02dcedfa0c57443122cf79314

Signature · 1 line
2.39.0