Skip to content

UEFI networking support including ipv6 + dhcpv6

Robbie Harwood grub-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest20 patches 2 repliesIn review
  2. v419 patches 2 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20Revert "net/http: Allow use of non-standard TCP/IP ports"docs/grub.texi grub-core/net/http.c+2 -711 reply
2/20net: read bracketed ipv6 addrs and port numbersdocs/grub.texi grub-core/net/http.c grub-core/net/net.c +2 more+104 -101 reply
3/20net/http: check result of grub_netbuff_put() in http_receive()grub-core/net/http.c+3 -10 replies
4/20efinet + bootp: add net_bootp6 command supporting dhcpv6grub-core/net/bootp.c grub-core/net/drivers/efi/efinet.c grub-core/net/ip.c +4 more+1267 -170 replies
5/20efinet: add structures for PXE messagesgrub-core/net/drivers/efi/efinet.c include/grub/efi/api.h+46 -270 replies
6/20grub.texi: Add net_bootp6 doumentationdocs/grub.texi+17 -00 replies
7/20bootp: Process DHCPACK packet during HTTP Bootgrub-core/net/bootp.c include/grub/net.h+56 -00 replies
8/20efinet Configure network from UEFI device pathgrub-core/net/drivers/efi/efinet.c include/grub/efi/api.h+274 -150 replies
9/20efinet: set DNS server from UEFI protocolgrub-core/net/drivers/efi/efinet.c include/grub/efi/api.h+237 -00 replies
10/20Support UEFI networking protocolsgrub-core/Makefile.core.def grub-core/io/bufio.c grub-core/kern/efi/efi.c +15 more+4529 -450 replies
11/20efinet: also use the firmware acceleration for httpgrub-core/net/efi/net.c+4 -10 replies
12/20efi/http: match protocol+hostname of boot url in root_urlgrub-core/net/efi/http.c+19 -00 replies
13/20Add fw_path variable to detect config file on efigrub-core/kern/main.c grub-core/normal/main.c+31 -80 replies
14/20use fw_path prefix when fallback searching for grub configgrub-core/normal/main.c+3 -20 replies
15/20Try mac/guid/etc before grub.cfg on tftp config filesgrub-core/kern/ieee1275/init.c grub-core/net/net.c grub-core/normal/main.c+82 -770 replies
16/20Prepend prefix when HTTP path is relativegrub-core/kern/main.c grub-core/net/efi/http.c+73 -220 replies
17/20efi/http: Enclose literal IPv6 addresses in square bracketsgrub-core/net/efi/http.c+28 -90 replies
18/20http: Prepend prefix when the HTTP path is relativegrub-core/net/http.c+9 -10 replies
19/20normal/main: Discover the device to read the config from as a fallbackgrub-core/normal/main.c+51 -70 replies
20/20efinet: Add DHCP proxy supportgrub-core/net/drivers/efi/efinet.c+25 -20 replies

Reviews trailers per patch

2 of 20 patches have a Reviewed-by or Acked-by.

PatchMichael ChangRobbie HarwoodJavier Martinez CanillasPeter JonesSebastian KrahmerAaron MillerDaniel Kiper
1/20R-b
2/20Co-authored-by Co-authored-by R-b
3/20Co-authored-by
4/20Co-authored-by Co-authored-by
5/20Co-authored-by
6/20
7/20
8/20
9/20
10/20Co-authored-by Co-authored-by Co-authored-by Co-authored-by
11/20
12/20
13/20Co-authored-by Co-authored-by
14/20
15/20
16/20Co-authored-by Co-authored-by
17/20
18/20Co-authored-by
19/20Co-authored-by
20/20Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/20] UEFI networking support including ipv6 + dhcpv6

This series is an omnibus of changes we carry for networking that has accumulated since at least 2015. While most of it did not receive review when previously posted, one did, so I'm using that as an excuse to call this v4.

At the start, this includes a proposed revert of ac8a37dda0eabdd80506bebe4fb9a5a9fd227935 ("net/http: Allow use of non-standard TCP/IP ports"). In 2016, a different approach to this more in keeping with the way port numbers are typically specified was posted on-list:
https://lists.gnu.org/archive/html/grub-devel/2016-04/msg00071.html [1]

At least Debian, Red Hat, SUSE, and Ubuntu have carried it since then, which means that code in the wild expects this syntax, not the other syntax. (Others may have as well - I didn't do an exhaustive check - but hopefully that's enough to convey the point.)

At this point, the division of code between patches is mostly organic. I've folded bugfixes into their original commits and moved a few other things around, so while this doesn't exactly match the division in the rhboot tree, it does match the code. At this version, the only code differences are style adjustments and rebasing around the vlan changes that merged since 2.06.

Changes since last version are to address review from dkiper. Notably, docs have been added to the bracketed ipv6 commit, and a new commit has been added for the grub_netbuff_put() error check.

Be well,
--Robbie

Ian Page Hands (1):
efinet: Add DHCP proxy support

Javier Martinez Canillas (3):
efi/http: Enclose literal IPv6 addresses in square brackets
http: Prepend prefix when the HTTP path is relative normal/main: Discover the device to read the config from as a fallback

Mark Salter (1):
use fw_path prefix when fallback searching for grub config

Michael Chang (6):
efinet: add structures for PXE messages
grub.texi: Add net_bootp6 doumentation
bootp: Process DHCPACK packet during HTTP Boot
efinet Configure network from UEFI device path
efinet: set DNS server from UEFI protocol
Support UEFI networking protocols

Paulo Flabiano Smorigo (1):
Add fw_path variable to detect config file on efi

Peter Jones (4):
efinet + bootp: add net_bootp6 command supporting dhcpv6
efinet: also use the firmware acceleration for http efi/http: match protocol+hostname of boot url in root_url Try mac/guid/etc before grub.cfg on tftp config files

Robbie Harwood (3):
Revert "net/http: Allow use of non-standard TCP/IP ports"
net: read bracketed ipv6 addrs and port numbers net/http: check result of grub_netbuff_put() in http_receive()

Stephen Benjamin (1):
Prepend prefix when HTTP path is relative

 docs/grub.texi                     |   54 +-
 grub-core/Makefile.core.def        |   12 +
 grub-core/io/bufio.c               |    2 +-
 grub-core/kern/efi/efi.c           |   96 +-
 grub-core/kern/ieee1275/init.c     |   28 +-
 grub-core/kern/main.c              |   22 +-
 grub-core/net/bootp.c              |  965 ++++++++++++++++++-
 grub-core/net/drivers/efi/efinet.c |  521 +++++++++-
 grub-core/net/efi/dhcp.c           |  357 +++++++
 grub-core/net/efi/efi_netfs.c      |   57 ++
 grub-core/net/efi/http.c           |  490 ++++++++++
 grub-core/net/efi/ip4_config.c     |  417 ++++++++
 grub-core/net/efi/ip6_config.c     |  423 +++++++++
 grub-core/net/efi/net.c            | 1416 ++++++++++++++++++++++++++++
 grub-core/net/efi/pxe.c            |  354 +++++++
 grub-core/net/http.c               |   73 +-
 grub-core/net/ip.c                 |   39 +
 grub-core/net/net.c                |  225 ++++-
 grub-core/net/tftp.c               |    9 +-
 grub-core/normal/main.c            |  149 ++-
 include/grub/efi/api.h             |  398 +++++++-
 include/grub/efi/dhcp.h            |  347 +++++++
 include/grub/efi/http.h            |  215 +++++
 include/grub/net.h                 |   81 ++
 include/grub/net/efi.h             |  144 +++
 util/grub-mknetdir.c               |   23 +-
 26 files changed, 6731 insertions(+), 186 deletions(-)
 create mode 100644 grub-core/net/efi/dhcp.c
 create mode 100644 grub-core/net/efi/efi_netfs.c
 create mode 100644 grub-core/net/efi/http.c
 create mode 100644 grub-core/net/efi/ip4_config.c
 create mode 100644 grub-core/net/efi/ip6_config.c
 create mode 100644 grub-core/net/efi/net.c
 create mode 100644 grub-core/net/efi/pxe.c
 create mode 100644 include/grub/efi/dhcp.h
 create mode 100644 include/grub/efi/http.h
 create mode 100644 include/grub/net/efi.h
Signature · 1 line
2.40.0