Skip to content

Device tree based NUMA support for Arm - Part#3

Wei Chen xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest17 patches 16 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKSxen/arch/arm/include/asm/numa.h xen/include/xen/numa.h+27 -12 replies
2/17xen/arm: implement helpers to get and update NUMA statusxen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c xen/arch/x86/include/asm/numa.h +1 more+62 -17 replies
3/17xen/arm: implement node distance helpers for Armxen/arch/arm/Makefile xen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c +3 more+68 -36 replies
4/17xen/arm: use arch_get_ram_range to memory ranges from bootinfoxen/arch/arm/numa.c+11 -00 replies
5/17xen/arm: build NUMA cpu_to_node map in dt_smp_init_cpusxen/arch/arm/include/asm/numa.h xen/arch/arm/smpboot.c+40 -00 replies
6/17xen/arm: Add boot and secondary CPU to NUMA systemxen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c xen/arch/arm/setup.c+24 -00 replies
7/17xen/arm: introduce a helper to parse device tree processor nodexen/arch/arm/Makefile xen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c +1 more+68 -10 replies
8/17xen/arm: introduce a helper to parse device tree memory nodexen/arch/arm/numa_device_tree.c+89 -00 replies
9/17xen/arm: introduce a helper to parse device tree NUMA distance mapxen/arch/arm/numa_device_tree.c+107 -00 replies
10/17xen/arm: unified entry to parse all NUMA data from device treexen/arch/arm/include/asm/numa.h xen/arch/arm/numa_device_tree.c+31 -00 replies
11/17xen/arm: keep guest still be NUMA unwarexen/arch/arm/domain_build.c+6 -00 replies
12/17xen/arm: enable device tree based NUMA in system initxen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c xen/arch/arm/setup.c+69 -00 replies
13/17xen/arm: implement numa_node_to_arch_nid for device tree NUMAxen/arch/arm/include/asm/numa.h+9 -00 replies
14/17xen/arm: use CONFIG_NUMA to gate node_online_map in smpbootxen/arch/arm/smpboot.c+2 -00 replies
15/17xen/arm: Set correct per-cpu cpu_core_maskxen/arch/arm/include/asm/numa.h xen/arch/arm/numa.c xen/arch/arm/setup.c+23 -00 replies
16/17xen/arm: Provide Kconfig options for Arm to enable NUMAxen/arch/arm/Kconfig+11 -00 replies
17/17docs: update numa command line to support ArmSUPPORT.md docs/misc/xen-command-line.pandoc+2 -11 reply

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by.

PatchStefano StabelliniJan Beulich
1/17
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17R-b
12/17
13/17
14/17
15/17
16/17
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/17] Device tree based NUMA support for Arm - Part#3

(The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts:
1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1]
2. Move generically usable code from x86 to common - merged in [2]
3. Add new code to support Arm - this series.

This series only contains the third part patches. As the whole NUMA series has been reviewed for 1 round in [3], so this series would be v2)

Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler.

Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system.

So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout.

Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts.

So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only.

This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine.

[1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg01043.html
[3] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html

Henry Wang (1):
xen/arm: Set correct per-cpu cpu_core_mask

Wei Chen (16):
xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS xen/arm: implement helpers to get and update NUMA status xen/arm: implement node distance helpers for Arm xen/arm: use arch_get_ram_range to memory ranges from bootinfo xen/arm: build NUMA cpu_to_node map in dt_smp_init_cpus xen/arm: Add boot and secondary CPU to NUMA system xen/arm: introduce a helper to parse device tree processor node xen/arm: introduce a helper to parse device tree memory node xen/arm: introduce a helper to parse device tree NUMA distance map xen/arm: unified entry to parse all NUMA data from device tree xen/arm: keep guest still be NUMA unware
xen/arm: enable device tree based NUMA in system init xen/arm: implement numa_node_to_arch_nid for device tree NUMA xen/arm: use CONFIG_NUMA to gate node_online_map in smpboot xen/arm: Provide Kconfig options for Arm to enable NUMA
docs: update numa command line to support Arm

 SUPPORT.md                        |   1 +
 docs/misc/xen-command-line.pandoc |   2 +-
 xen/arch/arm/Kconfig              |  11 ++
 xen/arch/arm/Makefile             |   2 +
 xen/arch/arm/domain_build.c       |   6 +
 xen/arch/arm/include/asm/numa.h   |  87 ++++++++-
 xen/arch/arm/numa.c               | 183 +++++++++++++++++++
 xen/arch/arm/numa_device_tree.c   | 290 ++++++++++++++++++++++++++++++
 xen/arch/arm/setup.c              |  17 ++
 xen/arch/arm/smpboot.c            |  38 ++++
 xen/arch/x86/include/asm/numa.h   |   2 -
 xen/arch/x86/srat.c               |   2 +-
 xen/include/xen/numa.h            |  11 ++
 13 files changed, 647 insertions(+), 5 deletions(-)
 create mode 100644 xen/arch/arm/numa.c
 create mode 100644 xen/arch/arm/numa_device_tree.c
Signature · 1 line
2.25.1