Skip to content

PCI: Fix extended config space regression

Bjorn Helgaas linux-pci lkml 1 version Applied

Status from this message: Applied to for-linus for v6.2. Sorry for the breakage and thank you

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 22 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86/pci: Simplify is_mmconf_reserved() messagesarch/x86/pci/mmconfig-shared.c+7 -62 replies
2/2x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM spacearch/x86/pci/mmconfig-shared.c+31 -015 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDan WilliamsRafael J. WysockiKan LiangTony LuckGiovanni CabidduYunying Sun
SeriesT-b T-b T-b T-b
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] PCI: Fix extended config space regression

From: Bjorn Helgaas <[email protected]>

07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared in v6.2-rc1 and broke extended config space on several machines.

This broke drivers that use things in extended config space, e.g., perf, VSEC telemetry, EDAC, QAT, etc.

This happened because mmconfig-shared.c checks to see that ECAM space is reserved in E820 or ACPI motherboard resources. If it's not, it assumes ECAM doesn't work. 07eab0901ede removed some E820 entries, so it looked like ECAM was no longer reserved, so we stopped using it.

The machines where this broke don't reserve the ECAM in ACPI PNP0C02 devices (which seems to be what the PCI Firmware spec requires), but they do mention it in the EFI memory map as EfiMemoryMappedIO.

Bjorn Helgaas (2):
x86/pci: Simplify is_mmconf_reserved() messages x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space

 arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1