Skip to content

fstests: filesystem population fixes

Dave Chinner fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3populate: fix horrible performance due to excessive forkingcommon/populate+104 -757 replies
2/3populate: ensure btree directories are created reliablycommon/populate+5 -22 replies
3/3xfs/294: performance is unreasonably slowtests/xfs/294+15 -42 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongDavid DisseldorpGao XiangZorro Lang
1/3
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] fstests: filesystem population fixes

Hi folks,

common/populate operations are slow. They are not coded for performance, and do things in very slow ways. Mainly doing loops to create/remove files and forcing a task to be created and destroy for every individual operation. We can only fork a few thousand processes a second, whilst we can create or remove tens of thousands of files a second. Hence population speed is limited by fork/exit overhead, not filesystem speed. I also changed it to run all the creation steps in parallel, which means they run as fast as the filesystem can handle them rather than as fast as a single CPU can handle them.

patch 1 and patch 3 address these issues for common/populate and xfs/294. I may update a bunch of other tests that use loop { touch file } to create thousands of files to speed them up as well.

The other patch in this series (patch 2) fixes the problem with populating an Xfs btree format directory, which currently fails because the removal step that creates sparse directory data also causes the dabtree index to get smaller and free blocks, taking the inode from btree to extent format and hence failing the populate checks.

More details are in the commit messages for change.

Cheers,

Dave.