Skip to content

RFC spice: Add an option to forward the dmabuf directly to the encoder (v2)

Vivek Kasireddy qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 7 repliesIn review
  2. v1 RFC2 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Used the already available gl_scanout and gl_draw_async APIs instead of adding new ones to Spice.
- Improved the commit message of the second patch

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2spice: Add an option for users to provide a preferred codecqemu-options.hx ui/spice-core.c+19 -01 reply
2/2spice: Add an option to forward the dmabuf directly to the encoder (v2)include/ui/spice-display.h qemu-options.hx ui/spice-core.c +1 more+81 -236 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC v2 0/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

This patch series adds options to select a preferred codec and also to forward a dmabuf directly to the encoder module that is part of the Spice server. Currently, gstreamer:h264 is the only combination tested but additional work is ongoing to test other combinations.

Tested with: -device virtio-gpu-pci,max_outputs=1,blob=true,xres=1920,yres=1080
-spice port=3001,gl=on,disable-ticketing=on,dmabuf-encode=on,
preferred-codec=gstreamer:h264

and remote-viewer --spice-debug spice://x.x.x.x:3001 on the client side.

Associated Spice server patches (v1) can be found here:
https://lists.freedesktop.org/archives/spice-devel/2023-January/052927.html

v2:
- Used the already available gl_scanout and gl_draw_async APIs instead of adding new ones to Spice.
- Improved the commit message of the second patch

Cc Gerd Hoffmann <[email protected]>
Cc Marc-André Lureau <[email protected]>
Cc Dongwon Kim <[email protected]>

Vivek Kasireddy (2):
spice: Add an option for users to provide a preferred codec
spice: Add an option to forward the dmabuf directly to the encoder

    (v2)
 include/ui/spice-display.h |  1 +
 qemu-options.hx            | 11 +++++-
 ui/spice-core.c            | 36 ++++++++++++++++--
 ui/spice-display.c         | 75 ++++++++++++++++++++++++++++----------
 4 files changed, 100 insertions(+), 23 deletions(-)
Signature · 1 line
2.37.2