driver core: make more things const!
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest16 patches 21 repliesIn review
Changes in v2 from the cover letter
- rebased on 6.2-rc1 and dropped accepted patches already in there.
- container_of_const() is now in 6.2-rc1 so use that in many individual subsystems to make the follow-on changes in the driver core more obvious.
- collected some Reviewed-by
- of_device_uevent_modalias was being "abused" by many different subsystems in using it instead of a local bus function which played havoc when enabling stricter type-checking. Move that out into a new function for the busses that were doing this to make it more obvious what they need here.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | of: device: make of_device_uevent_modalias() take a const device *arch/ drivers/ drivers/ +3 more | +28 | 4 replies | |
| 2/16 | i3c: move dev_to_i3cdev() to use container_of_const()drivers/ include/ | +8 | 1 reply | |
| 3/16 | platform/surface: aggregator: move to_ssam_device() to use container_of_const()include/ | +1 | 6 replies | |
| 4/16 | firewire: move fw_device() and fw_unit() to use container_of_const()include/ | +3 | 0 replies | |
| 5/16 | driver core: make struct device_type.uevent() take a const *block/ drivers/ drivers/ +22 more | +53 | 4 replies | |
| 6/16 | driver core: make struct device_type.devnode() take a const *block/ drivers/ drivers/ +4 more | +13 | 1 reply | |
| 7/16 | driver core: device_get_devnode() should take a const *drivers/ drivers/ include/ | +3 | 0 replies | |
| 8/16 | vio: move to_vio_dev() to use container_of_const()arch/ arch/ | +2 | 0 replies | |
| 9/16 | platform/x86: wmi: move dev_to_wblock() and dev_to_wdev to use container_of_const()drivers/ | +2 | 0 replies | |
| 10/16 | drivers: hv: move device_to_hv_device to use container_of_const()include/ | +1 | 1 reply | |
| 11/16 | virtio: move dev_to_virtio() to use container_of_const()include/ | +1 | 0 replies | |
| 12/16 | drm/mipi-dsi: move to_mipi_dsi_device() to use container_of_const()include/ | +1 | 0 replies | |
| 13/16 | mcb: move to_mcb_device() to use container_of_const()include/ | +1 | 0 replies | |
| 14/16 | xen/xenbus: move to_xenbus_device() to use container_of_const()include/ | +1 | 1 reply | |
| 15/16 | driver core: make struct bus_type.uevent() take a const *arch/ arch/ arch/ +78 more | +160 | 3 replies | |
| 16/16 | kobject: kset_uevent_ops: make uevent() callback take a const *drivers/ fs/ fs/ +1 more | +8 | 1 reply |
Reviews trailers per patch
9 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Rafael J. Wysocki | Mika Westerberg | Mauro Carvalho Chehab | Dan Williams | Andy Shevchenko | Wolfram Sang | Hans de Goede | Juergen Gross | Vinod Koul | Alexandre Belloni | Maximilian Luz | Heikki Krogerus | Wei Liu | Alexander Shishkin |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Series | A-b | |||||||||||||
| 1/16 | ||||||||||||||
| 2/16 | A-b | |||||||||||||
| 3/16 | R-b | |||||||||||||
| 4/16 | ||||||||||||||
| 5/16 | A-b | A-b | A-b | A-b | A-b | A-b | A-b | |||||||
| 6/16 | A-b | A-b | ||||||||||||
| 7/16 | A-b | R-b | ||||||||||||
| 8/16 | ||||||||||||||
| 9/16 | ||||||||||||||
| 10/16 | A-b | |||||||||||||
| 11/16 | ||||||||||||||
| 12/16 | ||||||||||||||
| 13/16 | ||||||||||||||
| 14/16 | A-b | |||||||||||||
| 15/16 | A-b | |||||||||||||
| 16/16 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 14 reviewers.
Cover letter [PATCH v2 00/16] driver core: make more things const!
Here's an updated version of this original series:
https://lore.kernel.org/all/[email protected]/
that has the goal of making more functions in the driver core take const pointers as they do not actually modify anything. This work is an outgrowth of some conversations I had with the Linux Rust developers talking about the mutability of many of the driver model pointers.
A small subset of the original submission is now in 6.2-rc1 and this series is an outgrown of the original submission in that many things are now changed and a bit more explicit than before.
I can take all of these through the driver-core git tree as they depend on each other. 0-day has been passing on this series for quite a while, so all should be good unless some subsystem trees have added new busses without me noticing.
Bonus for all of this work, the overall code size of the kernel actually decreased a tiny bit:
126 files changed, 283 insertions(+), 309 deletions(-)
while adding a lot more type-safeness to the system.
Changes from v1:
- rebased on 6.2-rc1 and dropped accepted patches already in there.
- container_of_const() is now in 6.2-rc1 so use that in many individual subsystems to make the follow-on changes in the driver core more obvious.
- collected some Reviewed-by
- of_device_uevent_modalias was being "abused" by many different subsystems in using it instead of a local bus function which played havoc when enabling stricter type-checking. Move that out into a new function for the busses that were doing this to make it more obvious what they need here.
Greg Kroah-Hartman (16):
of: device: make of_device_uevent_modalias() take a const device *
i3c: move dev_to_i3cdev() to use container_of_const() platform/surface: aggregator: move to_ssam_device() to use
container_of_const()
firewire: move fw_device() and fw_unit() to use container_of_const() driver core: make struct device_type.uevent() take a const * driver core: make struct device_type.devnode() take a const * driver core: device_get_devnode() should take a const *
vio: move to_vio_dev() to use container_of_const() platform/x86: wmi: move dev_to_wblock() and dev_to_wdev to use
container_of_const()
drivers: hv: move device_to_hv_device to use container_of_const()
virtio: move dev_to_virtio() to use container_of_const() drm/mipi-dsi: move to_mipi_dsi_device() to use container_of_const()
mcb: move to_mcb_device() to use container_of_const() xen/xenbus: move to_xenbus_device() to use container_of_const() driver core: make struct bus_type.uevent() take a const *
kobject: kset_uevent_ops: make uevent() callback take a const *
arch/mips/sgi-ip22/ip22-gio.c | 4 ++-- arch/parisc/kernel/drivers.c | 4 ++-- arch/powerpc/include/asm/vio.h | 5 +---- arch/powerpc/platforms/pseries/ibmebus.c | 7 ++++++- arch/powerpc/platforms/pseries/vio.c | 4 ++-- arch/sparc/include/asm/vio.h | 5 +---- arch/sparc/kernel/vio.c | 2 +- block/genhd.c | 2 +- block/partitions/core.c | 4 ++-- drivers/acpi/bus.c | 2 +- drivers/acpi/device_sysfs.c | 8 ++++---- drivers/acpi/internal.h | 2 +- drivers/amba/bus.c | 4 ++-- drivers/base/auxiliary.c | 2 +- drivers/base/base.h | 2 ++ drivers/base/core.c | 6 +++--- drivers/base/cpu.c | 2 +- drivers/base/platform.c | 4 ++-- drivers/bcma/main.c | 6 +++--- drivers/bus/fsl-mc/fsl-mc-bus.c | 4 ++-- drivers/bus/mhi/ep/main.c | 4 ++-- drivers/bus/mhi/host/init.c | 4 ++-- drivers/bus/mips_cdmm.c | 4 ++-- drivers/bus/sunxi-rsb.c | 7 ++++++- drivers/cxl/core/memdev.c | 4 ++-- drivers/cxl/core/port.c | 8 ++++---- drivers/cxl/cxl.h | 4 ++-- drivers/cxl/cxlmem.h | 2 +- drivers/dax/bus.c | 2 +- drivers/eisa/eisa-bus.c | 4 ++-- drivers/firewire/core-device.c | 8 ++++---- drivers/firmware/arm_ffa/bus.c | 4 ++-- drivers/fpga/dfl.c | 4 ++-- drivers/fsi/fsi-core.c | 6 +++--- drivers/gpu/drm/display/drm_dp_aux_bus.c | 7 ++++++- drivers/gpu/drm/drm_mipi_dsi.c | 4 ++-- drivers/gpu/host1x/bus.c | 2 +- drivers/greybus/core.c | 14 +++++++------- drivers/hid/hid-core.c | 4 ++-- drivers/hid/intel-ish-hid/ishtp/bus.c | 2 +- drivers/hsi/hsi_core.c | 2 +- drivers/hv/vmbus_drv.c | 4 ++-- drivers/hwtracing/intel_th/core.c | 6 +++--- drivers/hwtracing/intel_th/intel_th.h | 4 ++-- drivers/i2c/i2c-core-base.c | 4 ++-- drivers/i3c/device.c | 14 +------------- drivers/i3c/master.c | 4 ++-- drivers/input/input.c | 16 ++++++++-------- drivers/input/serio/serio.c | 4 ++-- drivers/ipack/ipack.c | 4 ++-- drivers/macintosh/macio_asic.c | 7 ++++++- drivers/mcb/mcb-core.c | 4 ++-- drivers/media/rc/rc-main.c | 2 +- drivers/memstick/core/memstick.c | 6 +++--- drivers/misc/mei/bus.c | 4 ++-- drivers/misc/tifm_core.c | 4 ++-- drivers/mmc/core/bus.c | 4 ++-- drivers/mmc/core/sdio_bus.c | 4 ++-- drivers/net/phy/mdio_bus.c | 2 +- drivers/net/xen-netback/xenbus.c | 2 +- drivers/nvdimm/bus.c | 4 ++-- drivers/nvdimm/dax_devs.c | 2 +- drivers/nvdimm/dimm_devs.c | 2 +- drivers/nvdimm/nd-core.h | 10 +++++----- drivers/nvdimm/nd.h | 4 ++-- drivers/nvdimm/region_devs.c | 4 ++-- drivers/of/device.c | 4 ++-- drivers/pci/pci-driver.c | 4 ++-- drivers/pcmcia/ds.c | 4 ++-- drivers/platform/surface/aggregator/bus.c | 4 ++-- drivers/platform/x86/wmi.c | 15 ++++----------- drivers/rapidio/rio-driver.c | 4 ++-- drivers/rpmsg/rpmsg_core.c | 4 ++-- drivers/s390/cio/css.c | 4 ++-- drivers/s390/cio/device.c | 8 ++++---- drivers/s390/cio/scm.c | 2 +- drivers/s390/crypto/ap_bus.c | 4 ++-- drivers/scsi/scsi_sysfs.c | 4 ++-- drivers/slimbus/core.c | 4 ++-- drivers/soc/qcom/apr.c | 4 ++-- drivers/soundwire/bus_type.c | 4 ++-- drivers/spi/spi.c | 2 +- drivers/spmi/spmi.c | 2 +- drivers/ssb/main.c | 4 ++-- drivers/staging/greybus/gbphy.c | 14 +++++++------- drivers/tee/tee_core.c | 2 +- drivers/thunderbolt/switch.c | 4 ++-- drivers/thunderbolt/tb.h | 2 +- drivers/thunderbolt/xdomain.c | 6 +++--- drivers/tty/serdev/core.c | 2 +- drivers/usb/common/ulpi.c | 4 ++-- drivers/usb/core/driver.c | 6 +++--- drivers/usb/core/message.c | 8 ++++---- drivers/usb/core/usb.c | 8 ++++---- drivers/usb/phy/phy.c | 6 +++--- drivers/usb/roles/class.c | 3 +-- drivers/usb/typec/bus.c | 4 ++-- drivers/usb/typec/class.c | 2 +- drivers/virtio/virtio.c | 4 ++-- drivers/w1/w1.c | 10 +++++----- drivers/xen/pvcalls-back.c | 2 +- drivers/xen/xenbus/xenbus_probe_backend.c | 8 ++++---- drivers/xen/xenbus/xenbus_probe_frontend.c | 4 ++-- drivers/zorro/zorro-driver.c | 4 ++-- fs/dlm/lockspace.c | 4 ++-- fs/gfs2/sys.c | 6 +++--- include/drm/drm_mipi_dsi.h | 5 +---- include/linux/acpi.h | 4 ++-- include/linux/device.h | 6 ++---- include/linux/device/bus.h | 2 +- include/linux/firewire.h | 15 +++------------ include/linux/hyperv.h | 5 +---- include/linux/i3c/device.h | 11 +++++++++-- include/linux/kobject.h | 2 +- include/linux/mcb.h | 5 +---- include/linux/of_device.h | 4 ++-- include/linux/soundwire/sdw_type.h | 2 +- include/linux/spi/spi.h | 2 +- include/linux/ssb/ssb.h | 2 +- include/linux/surface_aggregator/device.h | 5 +---- include/linux/virtio.h | 5 +---- include/sound/hdaudio.h | 2 +- include/xen/xenbus.h | 7 ++----- sound/aoa/soundbus/core.c | 6 +++--- sound/hda/hda_bus_type.c | 2 +- sound/hda/hdac_device.c | 2 +- 126 files changed, 283 insertions(+), 309 deletions(-)
Signature · 1 line
2.39.0