Skip to content

RFC NIC driver Rx ring ECN

[email protected] netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: NIC driver Rx ring ECN: skbuff and tcp supportinclude/linux/skbuff.h net/core/skbuff.c net/ipv4/tcp_input.c+10 -10 replies
2/7net: NIC driver Rx ring ECN: stats counterinclude/uapi/linux/snmp.h net/ipv4/ip_input.c net/ipv4/proc.c +2 more+12 -00 replies
3/7drivers: net: xgene: NIC driver Rx ring ECNdrivers/net/ethernet/apm/xgene/xgene_enet_main.c+6 -20 replies
4/7drivers: net: bnx2x: NIC driver Rx ring ECNdrivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+3 -30 replies
5/7drivers: net: bnx2x: NIC driver Rx ring ECNdrivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+6 -00 replies
6/7drivers: net: bnx2: NIC driver Rx ring ECNdrivers/net/ethernet/broadcom/bnx2.c+2 -20 replies
7/7drivers: net: bnx2: NIC driver Rx ring ECNdrivers/net/ethernet/broadcom/bnx2.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/7] NIC driver Rx ring ECN

From: Jeremy Harris <[email protected]>

Routers and switches provide for mitigation of buffer overrun by marking IP packets as "Congestion Experienced" [RFC 3168]. Participating transport protocols can use these marks to throttle their send rates.

This patchset extends coverage to the receiving NIC/driver buffers.

We use an out-of-band mechanism, marking the sk_buff rather than the packet, to avoid need for DPI.

Participating NIC drivers are modified to add the marks. Participating transport protocols are modified to notice marks and combine with IP-level protocol marks.

Stats counters are incremented in ipv4 and ipv6 input processing, with results:

 $ nstat -sz *Congest*
 #kernel
 Ip6InCongestionPkts             0                  0.0
 IpExtInCongestionPkts           148454             0.0
 $ 

Both NIC drivers and transports can be incrementatlly upgraded to take advantage of the feature. Three example drivers are modified in this patchset.

Jeremy Harris (7):
net: NIC driver Rx ring ECN: skbuff and tcp support
net: NIC driver Rx ring ECN: stats counter
drivers: net: xgene: NIC driver Rx ring ECN
drivers: net: bnx2x: NIC driver Rx ring ECN
drivers: net: bnx2x: NIC driver Rx ring ECN
drivers: net: bnx2: NIC driver Rx ring ECN
drivers: net: bnx2: NIC driver Rx ring ECN

 drivers/net/ethernet/apm/xgene/xgene_enet_main.c |  8 ++++++--
 drivers/net/ethernet/broadcom/bnx2.c             | 11 +++++++++--
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 12 +++++++++---
 include/linux/skbuff.h                           |  2 ++
 include/uapi/linux/snmp.h                        |  1 +
 net/core/skbuff.c                                |  1 +
 net/ipv4/ip_input.c                              |  4 ++++
 net/ipv4/proc.c                                  |  1 +
 net/ipv4/tcp_input.c                             |  8 +++++++-
 net/ipv6/ip6_input.c                             |  5 +++++
 net/ipv6/proc.c                                  |  1 +
 11 files changed, 46 insertions(+), 8 deletions(-)

base-commit: 12c1604ae1a39bef87ac099f106594b4cb433b75

Signature · 1 line
2.39.0