fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word")
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | t6003: uncomment test '--max-age=c3, --topo-order't/ | +10 | 0 replies | |
| 2/3 | t6422: drop commented out codet/ | +0 | 0 replies | |
| 3/3 | t7527: use test_when_finished in 'case insensitive+preserving't/ | +1 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH v1 0/3] fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word")
[ I apologize for some people getting this twice -- I messed up when
invoking git send-email ]
Quoted 10 lines · Eric Sunshine
Not related to your patch at all, but I notice in this test that the call to
test_when_finished()is commented out:# test_when_finished "stop_daemon_delete_repo test_insensitive" &&which makes me wonder if it was commented out while the test was being debugged but then forgotten, and that the script is now potentially leaking a running daemon if something in the test fails after the daemon was started, or if the daemon does not shut down on its own as it's supposed to do. [cc:+Jeff Hostetler]
Here's a patch series that fixes some of the commented out test code.
I skipped changing the following:
1. a minute-long test_expect_failure is commented out in t0014-alias.sh . Technically, this could be uncommented and marked with EXPENSIVE prerequisite, but it doesn't seem worth it for a test_expect_failure. [ cc Tim Schumacher, who added this test in fef5f7fc43 (t0014: introduce an alias testing suite, 2018-09-16) ]
2. In t6426-merge-skip-unneeded-updates.sh, second part of the test '2c: Modify b & add c VS rename b->c' is commented out with an explicit "# FIXME:
rename/add conflicts are horribly broken right now;" above the commented out part.
[ cc Elijah Newren, author of c04ba51739 (t6046: testcases checking whether updates can be skipped in a merge, 2018-04-19) ]
3. I've experimented a bit with commented out test in file t9200-git-cvsexportcommit.sh. Tests in this file rely on state from previous tests, which complicates more thorough investigation. Unfortunately, I didn't have bandwidth to investigate this further.
[ cc Robin Rosenberg, who added it in fe142b3a45 (Rework cvsexportcommit to handle binary files for all cases., 2006-11-12) and commented out in e86ad71fe5 (Make cvsexportcommit work with filenames with spaces and non-ascii characters., 2006-12-11) ]
I found these places in tests with:
git grep -P '^\s*[#]\s*test_' -- 't/t[0-9]*'
The rest of the results of this grep are documentation comments.
Andrei Rybak (3):
t6003: uncomment test '--max-age=c3, --topo-order'
t6422: drop commented out code
t7527: uncomment test_when_finished step in a test
t/t6003-rev-list-topo-order.sh | 23 ++++++++++------------- t/t6422-merge-rename-corner-cases.sh | 2 -- t/t7527-builtin-fsmonitor.sh | 2 +- 3 files changed, 11 insertions(+), 16 deletions(-)
Signature · 1 line
2.39.0