Skip to content

fs: dlm: better handling for new stop/start testcase

Alexander Aring cluster-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8fs: dlm: bring back previously shutdown handlingfs/dlm/lowcomms.c fs/dlm/midcomms.c+63 -340 replies
2/8fs: dlm: change to ignore unexpected non dlm opts msgsfs/dlm/midcomms.c+2 -100 replies
3/8fs: dlm: wait until all midcomms nodes detects versionfs/dlm/lockspace.c fs/dlm/midcomms.c fs/dlm/midcomms.h+27 -00 replies
4/8fs: dlm: make dlm sequence id handling more robustfs/dlm/lockspace.c+1 -10 replies
5/8fs: dlm: reduce the timeout time to 5 secsfs/dlm/midcomms.c+1 -10 replies
6/8fs: dlm: remove newline in log_printfs/dlm/midcomms.c+4 -40 replies
7/8fs: dlm: move state change into else branchfs/dlm/midcomms.c+4 -30 replies
8/8fs: dlm: remove unnecessary waker_up() callsfs/dlm/midcomms.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [PATCH dlm/next 0/8] fs: dlm: better handling for new stop/start testcase

Hi,

I previously send some patches which should queued up for stable. This patches tries to make the behaviour better for the midcomms layer in a very specific corner case of invoking stop/start of midcomms/lowcomms in a looping behaviour.

I am using dlm_locktorture module which isn't upstream but can be found at [0]. Have it as a module, I am doing a:

while true;do modprobe dlm_locktorture cluster=gohan;rmmod dlm_locktorture;done

on all cluster nodes will invoke the testcase which tests a specific corner case to call midcomms/lowcomms start and stop again on all cluster nodes. Between we might have some locking requests happening. Those patches makes this specific corner case better to handle, it's still not perfect and in futurue we should look again into this specific behaviour of adding/removing lockspaces in a looping behaviour. However it is a very corner testcase which probably does not occur a lot in practice. We might also need to try to simplify the whole process and have a better behaviour for dlm version detection as it's currently is.

- Alex

[0] https://gitlab.com/netcoder/linux-public/-/commit/cb67a3c99f0eb1e5860a9e27015e6dbd00bbcc34

Alexander Aring (8):
fs: dlm: bring back previously shutdown handling
fs: dlm: change to ignore unexpected non dlm opts msgs
fs: dlm: wait until all midcomms nodes detects version
fs: dlm: make dlm sequence id handling more robust
fs: dlm: reduce the timeout time to 5 secs
fs: dlm: remove newline in log_print
fs: dlm: move state change into else branch
fs: dlm: remove unnecessary waker_up() calls

 fs/dlm/lockspace.c |  5 ++-
 fs/dlm/lowcomms.c  | 77 +++++++++++++++++++++++++++++++++-------------
 fs/dlm/midcomms.c  | 74 ++++++++++++++++++++++++--------------------
 fs/dlm/midcomms.h  |  1 +
 4 files changed, 102 insertions(+), 55 deletions(-)
Signature · 1 line
2.31.1