Skip to content

RFC drm/mipi-dsi: 16-bit Brightness Endianness Fix

Richard Acayan dri-devel lkml 3 versions – Applied

Status from this message: Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest3 patches 6 repliesApplied
  2. v2 RFC2 patches 2 repliesSuperseded
  3. v1 RFC1 patch 4 repliesSuperseded

Changes in v3 from the cover letter

- patch vtdr6130 to use _large (3/3)
- remove Change-Id again (1/3)
- change patch subject (1-2/3)
- correct function name in patch description (2/3)
- add Tested-by tags (1-2/3)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightnessdrivers/gpu/drm/drm_mipi_dsi.c include/drm/drm_mipi_dsi.h+56 -01 reply
2/3drm/panel: sofef00: Use 16-bit brightness functiondrivers/gpu/drm/panel/panel-samsung-sofef00.c+2 -71 reply
3/3drm/panel: vtdr6130: Use 16-bit brightness functiondrivers/gpu/drm/panel/panel-visionox-vtdr6130.c+1 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCaleb ConnollyNeil ArmstrongSam Ravnborg
SeriesR-b
1/3T-b R-b
2/3T-b R-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [RFC PATCH v3 0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix

Changes since v2 ([email protected]):
- patch vtdr6130 to use _large (3/3)
- remove Change-Id again (1/3)
- change patch subject (1-2/3)
- correct function name in patch description (2/3)
- add Tested-by tags (1-2/3)

Changes since v1 ([email protected]):
- move 16-bit brightness handling to new functions and revert API change (1/2)
- remove Change-Id in compliance with checkpatch.pl (1/2)
- separate panel driver changes (2/2)

This series adds proper support for 16-bit MIPI DSI brightness and cleans up existing panel drivers with 16-bit brightness.

Both setting and getting works on an external S6E3FA7 (max_brightness = 1023) panel driver with the first patch.

Even though this originally fixed both 8-bit and 16-bit brightness, the 8-bit fix is omitted for now because it affects ~13 panels that would need to be tested:

    panel-asus-z00t-tm5p5-n35596.c
    panel-boe-bf060y8m-aj0.c
    panel-dsi-cm.c
    panel-ebbg-ft8719.c
    panel-jdi-fhd-r63452.c
    panel-jdi-lt070me05000.c
    panel-novatek-nt35510.c
    panel-novatek-nt35560.c
    panel-orisetech-otm8009a.c
    panel-raydium-rm67191.c
    panel-samsung-s6e63j0x03.c
    panel-sony-acx565akm.c
    panel-sony-tulip-truly-nt35521.c

Daniel Mentz (1):
drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness

Richard Acayan (2):
drm/panel: sofef00: Use 16-bit brightness function drm/panel: vtdr6130: Use 16-bit brightness function

 drivers/gpu/drm/drm_mipi_dsi.c                | 52 +++++++++++++++++++
 drivers/gpu/drm/panel/panel-samsung-sofef00.c |  9 +---
 .../gpu/drm/panel/panel-visionox-vtdr6130.c   |  5 +-
 include/drm/drm_mipi_dsi.h                    |  4 ++
 4 files changed, 59 insertions(+), 11 deletions(-)
Signature · 1 line
2.39.0