Skip to content

mmc: sdhci: Remove SDHCI_QUIRK_MISSING_CAPS

Adrian Hunter linux-mmc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mmc: sdhci-pci: Replace SDHCI_QUIRK_MISSING_CAPS for Ricoh controllerdrivers/mmc/host/sdhci-pci-core.c+5 -30 replies
2/6mmc: sdhci-brcmstb: Replace SDHCI_QUIRK_MISSING_CAPSdrivers/mmc/host/sdhci-brcmstb.c+1 -31 reply
3/6mmc: sdhci-sprd: Replace SDHCI_QUIRK_MISSING_CAPSdrivers/mmc/host/sdhci-sprd.c+2 -41 reply
4/6mmc: sdhci-pxav3: Replace SDHCI_QUIRK_MISSING_CAPSdrivers/mmc/host/sdhci-pxav3.c+1 -31 reply
5/6mmc: sdhci-iproc: Replace SDHCI_QUIRK_MISSING_CAPSdrivers/mmc/host/sdhci-iproc.c+8 -61 reply
6/6mmc: sdhci: Remove SDHCI_QUIRK_MISSING_CAPSdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+0 -50 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchScott BrandenFlorian FainelliJisheng ZhangChunyan Zhang
1/6
2/6Reviwed-by
3/6A-b
4/6R-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] mmc: sdhci: Remove SDHCI_QUIRK_MISSING_CAPS

Hi

This patch set is to remove SDHCI_QUIRK_MISSING_CAPS.

SDHCI_QUIRK_MISSING_CAPS is not needed because __sdhci_read_caps() can be called instead.

__sdhci_read_caps() is also called from sdhci_setup_host() via sdhci_read_caps(), however only the first call to __sdhci_read_caps() does anything because after that host->read_caps has been set to true.

Note, __sdhci_read_caps() does more than just set host->caps, such as do a reset, so calling __sdhci_read_caps() earlier could have unforeseen side-effects. However code flow has been reviewed with that in mind.

Adrian Hunter (6):
mmc: sdhci-pci: Replace SDHCI_QUIRK_MISSING_CAPS for Ricoh controller
mmc: sdhci-brcmstb: Replace SDHCI_QUIRK_MISSING_CAPS
mmc: sdhci-sprd: Replace SDHCI_QUIRK_MISSING_CAPS
mmc: sdhci-pxav3: Replace SDHCI_QUIRK_MISSING_CAPS
mmc: sdhci-iproc: Replace SDHCI_QUIRK_MISSING_CAPS
mmc: sdhci: Remove SDHCI_QUIRK_MISSING_CAPS

 drivers/mmc/host/sdhci-brcmstb.c  |  4 +---
 drivers/mmc/host/sdhci-iproc.c    | 14 ++++++++------
 drivers/mmc/host/sdhci-pci-core.c |  8 +++++---
 drivers/mmc/host/sdhci-pxav3.c    |  4 +---
 drivers/mmc/host/sdhci-sprd.c     |  6 ++----
 drivers/mmc/host/sdhci.c          |  3 ---
 drivers/mmc/host/sdhci.h          |  2 --
 7 files changed, 17 insertions(+), 24 deletions(-)

Regards
Adrian