Skip to content

audio: remove deprecated QEMU_AUDIO env support

Daniel P. Berrangé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9audio: don't check qemu_add_vm_change_state_handler failureaudio/audio.c+1 -61 reply
2/9audio: remove special audio_calloc functionaudio/alsaaudio.c audio/audio.c audio/audio_int.h +3 more+20 -482 replies
3/9audio: remove unused 'name' in QEMUSoundCard structaudio/audio.c audio/audio.h+0 -30 replies
4/9audio: remove QEMUSoundCard linked listaudio/audio.c audio/audio.h audio/audio_int.h+0 -70 replies
5/9audio: remove empty AUD_remove_card methodaudio/audio.c audio/audio.h hw/audio/ac97.c +6 more+0 -120 replies
6/9docs: split the deprecation warning for soundcards vs VNCdocs/about/deprecated.rst+9 -50 replies
7/9ui/vnc: don't accept VNC_ENCODING_AUDIO without audiodevdocs/about/deprecated.rst docs/about/removed-features.rst ui/vnc.c+15 -70 replies
8/9audio: audio state is now mandatory for captureaudio/audio.c+0 -70 replies
9/9audio: remove support for QEMU_AUDIO_ env variablesaudio/audio.c audio/audio.h audio/audio_legacy.c +5 more+14 -5890 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchVolker Rümelin
1/9R-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] audio: remove deprecated QEMU_AUDIO env support

This removes much of the deprecated audio code, most notably the QEMU_AUDIO env variables. The VNC server will also stop accepting client requests for audio streaming unless an audiodev is set.

I tried to make the use of 'audiodev' mandatory for devices but that turned out to not be practical. Our test suite assumes it can create any device type without setting any properties. This is not possible if 'audiodev' setting is enforced at realize() time. Also there are several machihe boards with embedded soundcards that provide no way to set audiodev AFAICT

Daniel P. Berrangé (9):
audio: don't check qemu_add_vm_change_state_handler failure
audio: remove special audio_calloc function
audio: remove unused 'name' in QEMUSoundCard struct
audio: remove QEMUSoundCard linked list
audio: remove empty AUD_remove_card method
docs: split the deprecation warning for soundcards vs VNC ui/vnc: don't accept VNC_ENCODING_AUDIO without audiodev
audio: audio state is now mandatory for capture
audio: remove support for QEMU_AUDIO_ env variables

 audio/alsaaudio.c               |   6 +-
 audio/audio.c                   |  71 +---
 audio/audio.h                   |   4 -
 audio/audio_int.h               |   2 -
 audio/audio_legacy.c            | 552 --------------------------------
 audio/audio_template.h          |  28 +-
 audio/meson.build               |   1 -
 audio/mixeng.c                  |   7 +-
 docs/about/deprecated.rst       |  16 +-
 docs/about/removed-features.rst |  14 +
 hw/audio/ac97.c                 |   1 -
 hw/audio/adlib.c                |   1 -
 hw/audio/es1370.c               |   1 -
 hw/audio/gus.c                  |   1 -
 hw/audio/hda-codec.c            |   1 -
 hw/audio/wm8750.c               |   1 -
 hw/usb/dev-audio.c              |   1 -
 softmmu/vl.c                    |   4 -
 tests/qtest/fuzz-sb16-test.c    |   6 +-
 tests/qtest/libqtest.c          |   3 -
 ui/vnc.c                        |  10 +-
 21 files changed, 53 insertions(+), 678 deletions(-)
 delete mode 100644 audio/audio_legacy.c
Signature · 1 line
2.38.1