Skip to content

gpiolib: get rid of exessive ->of_gpio_ranges_fallback()

Andy Shevchenko linux-arm-kernel linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 8 repliesIn review

Changes in v3 from the cover letter

- moved check of the property presense to GPIO library
- split out the refcount fix in a separate patch
- added cover letter

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges()drivers/gpio/gpiolib.c+8 -00 replies
2/4pinctrl: bcm2835: Remove of_node_put() in bcm2835_of_gpio_ranges_fallback()drivers/pinctrl/bcm/pinctrl-bcm2835.c+0 -23 replies
3/4pinctrl: bcm2835: Switch to use ->add_pin_ranges()drivers/pinctrl/bcm/pinctrl-bcm2835.c+4 -40 replies
4/4Revert "gpiolib: of: Introduce hook for missing gpio-ranges"drivers/gpio/gpiolib-of.c include/linux/gpio/driver.h+0 -170 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan WahrenBartosz GolaszewskiFlorian Fainelli
SeriesT-b A-b T-b R-b
1/4
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/4] gpiolib: get rid of exessive ->of_gpio_ranges_fallback()

The ->of_gpio_ranges_fallback() repeats the idea that lies behind ->add_pin_ranges(), while the latter covers more cases that the former hook. Drop the former one for good.

Changelog v3:
- moved check of the property presense to GPIO library
- split out the refcount fix in a separate patch
- added cover letter

Andy Shevchenko (4):
gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges()
pinctrl: bcm2835: Remove of_node_put() in

    bcm2835_of_gpio_ranges_fallback()

pinctrl: bcm2835: Switch to use ->add_pin_ranges() Revert "gpiolib: of: Introduce hook for missing gpio-ranges"

 drivers/gpio/gpiolib-of.c             |  5 -----
 drivers/gpio/gpiolib.c                |  8 ++++++++
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------
 include/linux/gpio/driver.h           | 12 ------------
 4 files changed, 12 insertions(+), 23 deletions(-)
Signature · 1 line
2.39.0