ice: various virtualization cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest13 patches 17 repliesIn review
- v113 patches 12 repliesSuperseded
Changes in v2 from the cover letter
* drop "ice: add helper function for checking VSI VF requirements"
* add new patch "ice: refactor VSI setup to use parameter structure"
* Fix iRDMA use of hw_addr
* Fix printk format in WARN_ON
* Add Co-developed-by tag for "ice: add a function to initialize vf entry"
* Cleanup use of ice_set_vf_state_qs_dis
* Fix build failures reported by robot
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | ice: fix function comment referring to ice_vsi_allocdrivers/ | +1 | 0 replies | |
| 2/13 | ice: drop unnecessary VF parameter from several VSI functionsdrivers/ | +8 | 1 reply | |
| 3/13 | ice: refactor VSI setup to use parameter structuredrivers/ drivers/ drivers/ +3 more | +147 | 1 reply | |
| 4/13 | ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfgdrivers/ | +26 | 1 reply | |
| 5/13 | ice: Fix RDMA latency issue by allowing write-combiningdrivers/ drivers/ drivers/ +5 more | +219 | 5 replies | |
| 6/13 | ice: move ice_vf_vsi_release into ice_vf_lib.cdrivers/ drivers/ drivers/ | +19 | 1 reply | |
| 7/13 | ice: Pull common tasks into ice_vf_post_vsi_rebuilddrivers/ drivers/ | +17 | 1 reply | |
| 8/13 | ice: add a function to initialize vf entrydrivers/ drivers/ drivers/ | +29 | 1 reply | |
| 9/13 | ice: introduce ice_vf_init_host_cfg functiondrivers/ drivers/ drivers/ | +57 | 1 reply | |
| 10/13 | ice: convert vf_ops .vsi_rebuild to .create_vsidrivers/ drivers/ drivers/ | +40 | 0 replies | |
| 11/13 | ice: introduce clear_reset_state operationdrivers/ drivers/ drivers/ +1 more | +31 | 3 replies | |
| 12/13 | ice: introduce .irq_close VF operationdrivers/ drivers/ drivers/ | +6 | 1 reply | |
| 13/13 | ice: remove unnecessary virtchnl_ether_addr struct usedrivers/ drivers/ drivers/ +2 more | +35 | 1 reply |
Reviews trailers per patch
3 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Michal Swiatkowski | Paul Menzel | Gurucharan G | Jakub Andrysiak | Marek Szlosek |
|---|---|---|---|---|---|
| 1/13 | R-b | ||||
| 2/13 | R-b | T-b | |||
| 3/13 | T-b | ||||
| 4/13 | T-b | ||||
| 5/13 | T-b | ||||
| 6/13 | T-b | ||||
| 7/13 | T-b | ||||
| 8/13 | T-b | ||||
| 9/13 | T-b | ||||
| 10/13 | |||||
| 11/13 | R-b | T-b | |||
| 12/13 | T-b | ||||
| 13/13 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [Intel-wired-lan] [PATCH net-next v2 00/13] ice: various virtualization cleanups
This series contains a variety of refactors and cleanups in the VF code for the ice driver. Its primary focus is to cleanup a few areas of the driver before we begin implementing Scalable IOV.
This includes some cleanup and simplification of the VF operations and addition of a few new operations that will be required by Scalable IOV, as well as some other refactors needed for the handling of VF subfunctions.
It also contains a patch for changing the way we handle the mapping of the PCI BAR 0 registers to allow sparse maps. This is done to enable iRDMA to map the RDMA registers with write combining. Today, the iRDMA driver tries this, but since the ice driver already mapped them as uncachable, the write combining does not take effect. This results in additional latency as the write combining can't be used.
This is fixed by modifying the driver to perform its own iomaps to map the region before the RDMA space and the region after the space separately. We can't just reduce the size of the map because Scalable IOV will need the registers in the region beyond the RDMA area.
Changes since v1
* drop "ice: add helper function for checking VSI VF requirements"
* add new patch "ice: refactor VSI setup to use parameter structure"
* Fix iRDMA use of hw_addr
* Fix printk format in WARN_ON
* Add Co-developed-by tag for "ice: add a function to initialize vf entry"
* Cleanup use of ice_set_vf_state_qs_dis
* Fix build failures reported by robot
Jacob Keller (13):
ice: fix function comment referring to ice_vsi_alloc
ice: drop unnecessary VF parameter from several VSI functions
ice: refactor VSI setup to use parameter structure
ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfg
ice: Fix RDMA latency issue by allowing write-combining
ice: move ice_vf_vsi_release into ice_vf_lib.c
ice: Pull common tasks into ice_vf_post_vsi_rebuild
ice: add a function to initialize vf entry
ice: introduce ice_vf_init_host_cfg function
ice: convert vf_ops .vsi_rebuild to .create_vsi
ice: introduce clear_reset_state operation
ice: introduce .irq_close VF operation
ice: remove unnecessary virtchnl_ether_addr struct use
drivers/infiniband/hw/irdma/main.c | 2 +- drivers/net/ethernet/intel/ice/ice.h | 4 +- drivers/net/ethernet/intel/ice/ice_base.c | 5 +- drivers/net/ethernet/intel/ice/ice_eswitch.c | 26 ++- drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 +- drivers/net/ethernet/intel/ice/ice_lib.c | 138 ++++++----- drivers/net/ethernet/intel/ice/ice_lib.h | 52 ++++- drivers/net/ethernet/intel/ice/ice_main.c | 219 ++++++++++++++++-- drivers/net/ethernet/intel/ice/ice_osdep.h | 48 +++- drivers/net/ethernet/intel/ice/ice_sriov.c | 133 ++++------- drivers/net/ethernet/intel/ice/ice_txrx.h | 2 +- drivers/net/ethernet/intel/ice/ice_type.h | 2 +- drivers/net/ethernet/intel/ice/ice_vf_lib.c | 181 ++++++++++++++- drivers/net/ethernet/intel/ice/ice_vf_lib.h | 12 +- .../ethernet/intel/ice/ice_vf_lib_private.h | 3 + drivers/net/ethernet/intel/ice/ice_virtchnl.c | 24 +- 16 files changed, 621 insertions(+), 233 deletions(-)
base-commit: dd2bcc3ced4c47bead56ad9b728d7d5c3941cae2
Signature · 6 lines
2.39.1.405.gd4c25cc71f83 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan