Skip to content

ice: various virtualization cleanups

Jacob Keller intel-wired-lan netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 17 repliesIn review
  2. v113 patches 12 repliesSuperseded

Changes in v2 from the cover letter

* drop "ice: add helper function for checking VSI VF requirements"
* add new patch "ice: refactor VSI setup to use parameter structure"
* Fix iRDMA use of hw_addr
* Fix printk format in WARN_ON
* Add Co-developed-by tag for "ice: add a function to initialize vf entry"
* Cleanup use of ice_set_vf_state_qs_dis
* Fix build failures reported by robot

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ice: fix function comment referring to ice_vsi_allocdrivers/net/ethernet/intel/ice/ice_lib.c+1 -10 replies
2/13ice: drop unnecessary VF parameter from several VSI functionsdrivers/net/ethernet/intel/ice/ice_lib.c+8 -131 reply
3/13ice: refactor VSI setup to use parameter structuredrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_lib.h +3 more+147 -631 reply
4/13ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfgdrivers/net/ethernet/intel/ice/ice_lib.c+26 -251 reply
5/13ice: Fix RDMA latency issue by allowing write-combiningdrivers/infiniband/hw/irdma/main.c drivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_base.c +5 more+219 -245 replies
6/13ice: move ice_vf_vsi_release into ice_vf_lib.cdrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c drivers/net/ethernet/intel/ice/ice_vf_lib_private.h+19 -151 reply
7/13ice: Pull common tasks into ice_vf_post_vsi_rebuilddrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c+17 -41 reply
8/13ice: add a function to initialize vf entrydrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c drivers/net/ethernet/intel/ice/ice_vf_lib_private.h+29 -141 reply
9/13ice: introduce ice_vf_init_host_cfg functiondrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c drivers/net/ethernet/intel/ice/ice_vf_lib_private.h+57 -341 reply
10/13ice: convert vf_ops .vsi_rebuild to .create_vsidrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c drivers/net/ethernet/intel/ice/ice_vf_lib.h+40 -150 replies
11/13ice: introduce clear_reset_state operationdrivers/net/ethernet/intel/ice/ice_main.c drivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c +1 more+31 -43 replies
12/13ice: introduce .irq_close VF operationdrivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c drivers/net/ethernet/intel/ice/ice_vf_lib.h+6 -01 reply
13/13ice: remove unnecessary virtchnl_ether_addr struct usedrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_sriov.c drivers/net/ethernet/intel/ice/ice_vf_lib.c +2 more+35 -351 reply

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchMichal SwiatkowskiPaul MenzelGurucharan GJakub AndrysiakMarek Szlosek
1/13R-b
2/13R-b T-b
3/13T-b
4/13T-b
5/13T-b
6/13T-b
7/13T-b
8/13T-b
9/13T-b
10/13
11/13R-b T-b
12/13T-b
13/13T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [Intel-wired-lan] [PATCH net-next v2 00/13] ice: various virtualization cleanups

This series contains a variety of refactors and cleanups in the VF code for the ice driver. Its primary focus is to cleanup a few areas of the driver before we begin implementing Scalable IOV.

This includes some cleanup and simplification of the VF operations and addition of a few new operations that will be required by Scalable IOV, as well as some other refactors needed for the handling of VF subfunctions.

It also contains a patch for changing the way we handle the mapping of the PCI BAR 0 registers to allow sparse maps. This is done to enable iRDMA to map the RDMA registers with write combining. Today, the iRDMA driver tries this, but since the ice driver already mapped them as uncachable, the write combining does not take effect. This results in additional latency as the write combining can't be used.

This is fixed by modifying the driver to perform its own iomaps to map the region before the RDMA space and the region after the space separately. We can't just reduce the size of the map because Scalable IOV will need the registers in the region beyond the RDMA area.

Changes since v1
* drop "ice: add helper function for checking VSI VF requirements"
* add new patch "ice: refactor VSI setup to use parameter structure"
* Fix iRDMA use of hw_addr
* Fix printk format in WARN_ON
* Add Co-developed-by tag for "ice: add a function to initialize vf entry"
* Cleanup use of ice_set_vf_state_qs_dis
* Fix build failures reported by robot

Jacob Keller (13):
ice: fix function comment referring to ice_vsi_alloc
ice: drop unnecessary VF parameter from several VSI functions
ice: refactor VSI setup to use parameter structure
ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfg
ice: Fix RDMA latency issue by allowing write-combining
ice: move ice_vf_vsi_release into ice_vf_lib.c
ice: Pull common tasks into ice_vf_post_vsi_rebuild
ice: add a function to initialize vf entry
ice: introduce ice_vf_init_host_cfg function
ice: convert vf_ops .vsi_rebuild to .create_vsi
ice: introduce clear_reset_state operation
ice: introduce .irq_close VF operation
ice: remove unnecessary virtchnl_ether_addr struct use

 drivers/infiniband/hw/irdma/main.c            |   2 +-
 drivers/net/ethernet/intel/ice/ice.h          |   4 +-
 drivers/net/ethernet/intel/ice/ice_base.c     |   5 +-
 drivers/net/ethernet/intel/ice/ice_eswitch.c  |  26 ++-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |   3 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      | 138 ++++++-----
 drivers/net/ethernet/intel/ice/ice_lib.h      |  52 ++++-
 drivers/net/ethernet/intel/ice/ice_main.c     | 219 ++++++++++++++++--
 drivers/net/ethernet/intel/ice/ice_osdep.h    |  48 +++-
 drivers/net/ethernet/intel/ice/ice_sriov.c    | 133 ++++-------
 drivers/net/ethernet/intel/ice/ice_txrx.h     |   2 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |   2 +-
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 181 ++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  12 +-
 .../ethernet/intel/ice/ice_vf_lib_private.h   |   3 +
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |  24 +-
 16 files changed, 621 insertions(+), 233 deletions(-)

base-commit: dd2bcc3ced4c47bead56ad9b728d7d5c3941cae2

Signature · 6 lines
2.39.1.405.gd4c25cc71f83

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan