Skip to content

samples/bpf: modernize BPF functionality test programs

Daniel T. Lee bpf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10samples/bpf: ensure ipv6 is enabled before running testssamples/bpf/tc_l2_redirect.sh samples/bpf/test_cgrp2_sock2.sh samples/bpf/test_cgrp2_tc.sh+8 -10 replies
2/10samples/bpf: refactor BPF functionality testing scriptssamples/bpf/lwt_len_hist.sh samples/bpf/test_cgrp2_sock.sh samples/bpf/test_cgrp2_sock2.sh +2 more+22 -150 replies
3/10samples/bpf: fix broken lightweight tunnel testingsamples/bpf/test_lwt_bpf.c samples/bpf/test_lwt_bpf.sh+25 -220 replies
4/10samples/bpf: fix broken cgroup socket testingsamples/bpf/sock_flags_kern.c+6 -60 replies
5/10samples/bpf: replace broken overhead microbenchmark with fib_table_lookupsamples/bpf/test_overhead_kprobe_kern.c samples/bpf/test_overhead_raw_tp_kern.c samples/bpf/test_overhead_tp_kern.c +1 more+40 -180 replies
6/10samples/bpf: replace legacy map with the BTF-defined mapsamples/bpf/lwt_len_hist_kern.c samples/bpf/test_cgrp2_tc_kern.c+14 -350 replies
7/10samples/bpf: split common macros to net_shared.hsamples/bpf/net_shared.h samples/bpf/xdp_sample.bpf.h+27 -210 replies
8/10samples/bpf: replace BPF programs header with net_shared.hsamples/bpf/net_shared.h samples/bpf/sock_flags_kern.c samples/bpf/test_cgrp2_tc_kern.c +1 more+15 -100 replies
9/10samples/bpf: use vmlinux.h instead of implicit headers in BPF test programsamples/bpf/lwt_len_hist_kern.c samples/bpf/sock_flags_kern.c samples/bpf/test_cgrp2_tc_kern.c +5 more+12 -290 replies
10/10samples/bpf: change _kern suffix to .bpf with BPF test programssamples/bpf/Makefile samples/bpf/lwt_len_hist.bpf.c samples/bpf/lwt_len_hist.sh +10 more+14 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [bpf-next 00/10] samples/bpf: modernize BPF functionality test programs

Currently, there are many programs under samples/bpf to test the various functionality of BPF that have been developed for a long time. However, the kernel (BPF) has changed a lot compared to the 2016 when some of these test programs were first introduced.

Therefore, some of these programs use the deprecated function of BPF, and some programs no longer work normally due to changes in the API.

To list some of the kernel changes that this patch set is focusing on,
- legacy BPF map declaration syntax support had been dropped [1]
- bpf_trace_printk() always append newline at the end [2]
- deprecated styled BPF section header (bpf_load style) [3]
- urandom_read tracepoint is removed (used for testing overhead) [4]
- ping sends packet with SOCK_DGRAM instead of SOCK_RAW [5]*
- use "vmlinux.h" instead of including individual headers

In addition to this, this patchset tries to modernize the existing testing scripts a bit. And for network-related testing programs, a separate header file was created and applied. (To use the Endianness conversion function from xdp_sample and bunch of constants)

[1]: https://github.com/libbpf/libbpf/issues/282
[2]: commit ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()") [3]: commit ceb5dea56543 ("samples: bpf: Remove bpf_load loader completely") [4]: commit 14c174633f34 ("random: remove unused tracepoints")
[5]: https://lwn.net/Articles/422330/

*: This is quite old, but I'm not sure why the code was initially
developed to filter only SOCK_RAW.

Daniel T. Lee (10):
samples/bpf: ensure ipv6 is enabled before running tests samples/bpf: refactor BPF functionality testing scripts samples/bpf: fix broken lightweight tunnel testing samples/bpf: fix broken cgroup socket testing samples/bpf: replace broken overhead microbenchmark with
fib_table_lookup
samples/bpf: replace legacy map with the BTF-defined map samples/bpf: split common macros to net_shared.h samples/bpf: replace BPF programs header with net_shared.h samples/bpf: use vmlinux.h instead of implicit headers in BPF test
program
samples/bpf: change _kern suffix to .bpf with BPF test programs

 samples/bpf/Makefile                          | 14 +++---
 ...lwt_len_hist_kern.c => lwt_len_hist.bpf.c} | 29 +++--------
 samples/bpf/lwt_len_hist.sh                   |  4 +-
 samples/bpf/net_shared.h                      | 32 ++++++++++++
 .../{sock_flags_kern.c => sock_flags.bpf.c}   | 24 ++++-----
 samples/bpf/tc_l2_redirect.sh                 |  3 ++
 samples/bpf/test_cgrp2_sock.sh                | 16 +++---
 samples/bpf/test_cgrp2_sock2.sh               |  9 +++-
 ...st_cgrp2_tc_kern.c => test_cgrp2_tc.bpf.c} | 34 ++++---------
 samples/bpf/test_cgrp2_tc.sh                  |  8 +--
 samples/bpf/test_lwt_bpf.c                    | 50 ++++++++-----------
 samples/bpf/test_lwt_bpf.sh                   | 19 ++++---
 ...ap_in_map_kern.c => test_map_in_map.bpf.c} |  7 +--
 samples/bpf/test_map_in_map_user.c            |  2 +-
 ...robe_kern.c => test_overhead_kprobe.bpf.c} |  6 +--
 ...w_tp_kern.c => test_overhead_raw_tp.bpf.c} |  4 +-
 ...rhead_tp_kern.c => test_overhead_tp.bpf.c} | 29 +++++++----
 samples/bpf/test_overhead_user.c              | 34 ++++++++-----
 samples/bpf/xdp_sample.bpf.h                  | 22 +-------
 19 files changed, 179 insertions(+), 167 deletions(-)
 rename samples/bpf/{lwt_len_hist_kern.c => lwt_len_hist.bpf.c} (75%)
 create mode 100644 samples/bpf/net_shared.h
 rename samples/bpf/{sock_flags_kern.c => sock_flags.bpf.c} (66%)
 rename samples/bpf/{test_cgrp2_tc_kern.c => test_cgrp2_tc.bpf.c} (70%)
 rename samples/bpf/{test_map_in_map_kern.c => test_map_in_map.bpf.c} (97%)
 rename samples/bpf/{test_overhead_kprobe_kern.c => test_overhead_kprobe.bpf.c} (92%)
 rename samples/bpf/{test_overhead_raw_tp_kern.c => test_overhead_raw_tp.bpf.c} (82%)
 rename samples/bpf/{test_overhead_tp_kern.c => test_overhead_tp.bpf.c} (61%)
Signature · 1 line
2.34.1