Skip to content

drivers/s390/net/ism: Add generalized interface

Jan Karcher linux-s390 netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 5 repliesApplied 8/8
  2. v18 patches 2 repliesSuperseded

Changes in v2 from the cover letter

Removed s390x dependency which broke config for other archs.

Patches in v2 All 8 applied

#Subject and filesSizeRepliesApplied
1/8net/smc: Terminate connections prior to device removalnet/smc/smc_ism.c+2 -20 repliesApplied
2/8net/ism: Add missing calls to disable bus-masteringdrivers/s390/net/ism_drv.c+2 -00 repliesApplied
3/8s390/ism: Introduce struct ism_dmbdrivers/s390/net/ism.h drivers/s390/net/ism_drv.c include/linux/ism.h+40 -60 repliesApplied
4/8net/ism: Add new API for client registrationdrivers/s390/net/ism.h drivers/s390/net/ism_drv.c include/linux/ism.h +2 more+236 -360 repliesApplied
5/8net/smc: Register SMC-D as ISM clientdrivers/s390/net/ism_drv.c include/net/smc.h net/smc/af_smc.c +3 more+69 -350 repliesApplied
6/8net/smc: Separate SMC-D and ISM APIsdrivers/s390/net/ism_drv.c include/linux/ism.h include/net/smc.h +3 more+86 -360 repliesApplied
7/8s390/ism: Consolidate SMC-D-related codedrivers/s390/net/ism_drv.c include/linux/ism.h include/net/smc.h +1 more+143 -890 repliesApplied
8/8net/smc: De-tangle ism and smc device initializationdrivers/s390/net/ism_drv.c include/linux/ism.h include/net/smc.h +4 more+52 -820 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [net-next v2 0/8] drivers/s390/net/ism: Add generalized interface

Previously, there was no clean separation between SMC-D code and the ISM device driver.This patch series addresses the situation to make ISM available for uses outside of SMC-D.
In detail: SMC-D offers an interface via struct smcd_ops, which only the ISM module implements so far. However, there is no real separation between the smcd and ism modules, which starts right with the ISM device initialization, which calls directly into the SMC-D code.
This patch series introduces a new API in the ISM module, which allows registration of arbitrary clients via include/linux/ism.h: struct ism_client. Furthermore, it introduces a "pure" struct ism_dev (i.e. getting rid of dependencies on SMC-D in the device structure), and adds a number of API calls for data transfers via ISM (see ism_register_dmb() & friends). Still, the ISM module implements the SMC-D API, and therefore has a number of internal helper functions for that matter.
Note that the ISM API is consciously kept thin for now (as compared to the SMC-D API calls), as a number of API calls are only used with SMC-D and hardly have any meaningful usage beyond SMC-D, e.g. the VLAN-related calls.

v1 -> v2:
Removed s390x dependency which broke config for other archs.

Stefan Raspl (8):
net/smc: Terminate connections prior to device removal net/ism: Add missing calls to disable bus-mastering s390/ism: Introduce struct ism_dmb
net/ism: Add new API for client registration net/smc: Register SMC-D as ISM client net/smc: Separate SMC-D and ISM APIs s390/ism: Consolidate SMC-D-related code net/smc: De-tangle ism and smc device initialization

 drivers/s390/net/ism.h     |  19 +-
 drivers/s390/net/ism_drv.c | 376 ++++++++++++++++++++++++++++++-------
 include/linux/ism.h        |  98 ++++++++++
 include/net/smc.h          |  24 +--
 net/smc/af_smc.c           |   9 +-
 net/smc/smc_clc.c          |  11 +-
 net/smc/smc_core.c         |  13 +-
 net/smc/smc_diag.c         |   3 +-
 net/smc/smc_ism.c          | 180 ++++++++++--------
 net/smc/smc_ism.h          |   3 +-
 net/smc/smc_pnet.c         |  40 ++--
 11 files changed, 560 insertions(+), 216 deletions(-)
 create mode 100644 include/linux/ism.h
Signature · 1 line
2.25.1