Skip to content

drm: Remove includes for drm_crtc_helper.h

Thomas Zimmermann amd-gfx dri-devel linux-arm-kernel linux-aspeed linux-mips linux-renesas-soc linux-rockchip linux-sunxi nouveau 1 version Applied

Status from this message: Applied. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/22drm/amdgpu: Fix coding styledrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+2 -21 reply
2/22drm: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/drm_crtc_helper.c drivers/gpu/drm/drm_lease.c drivers/gpu/drm/drm_plane_helper.c +1 more+2 -31 reply
3/22drm/amdgpu: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +9 more+12 -51 reply
4/22drm/arm/komeda: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/arm/display/komeda/komeda_crtc.c drivers/gpu/drm/arm/display/komeda/komeda_kms.h+0 -20 replies
5/22drm/aspeed: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/aspeed/aspeed_gfx_crtc.c drivers/gpu/drm/aspeed/aspeed_gfx_drv.c drivers/gpu/drm/aspeed/aspeed_gfx_out.c+0 -31 reply
6/22drm/ast: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mode.c+0 -30 replies
7/22drm/bridge: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/bridge/analogix/analogix-anx6345.c drivers/gpu/drm/bridge/analogix/anx7625.c drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +4 more+0 -70 replies
8/22drm/gma500: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/gma500/cdv_device.c drivers/gpu/drm/gma500/cdv_intel_crt.c drivers/gpu/drm/gma500/cdv_intel_display.c +13 more+25 -10 replies
9/22drm/i2c/ch7006: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/i2c/ch7006_drv.c drivers/gpu/drm/i2c/ch7006_priv.h+2 -10 replies
10/22drm/ingenic: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/ingenic/ingenic-drm-drv.c+0 -10 replies
11/22drm/kmb: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/kmb/kmb_crtc.c drivers/gpu/drm/kmb/kmb_plane.c+0 -20 replies
12/22drm/logicvc: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/logicvc/logicvc_interface.c drivers/gpu/drm/logicvc/logicvc_mode.c+0 -20 replies
13/22drm/nouveau: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/nouveau/dispnv04/crtc.c drivers/gpu/drm/nouveau/dispnv04/dac.c drivers/gpu/drm/nouveau/dispnv04/dfp.c +6 more+5 -70 replies
14/22drm/radeon: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/radeon/atombios_crtc.c drivers/gpu/drm/radeon/atombios_encoders.c drivers/gpu/drm/radeon/r300.c +10 more+7 -100 replies
15/22drm/rockchip: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/rockchip/rockchip_drm_vop2.c+0 -10 replies
16/22drm/shmobile: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/shmobile/shmob_drm_crtc.c drivers/gpu/drm/shmobile/shmob_drm_drv.c drivers/gpu/drm/shmobile/shmob_drm_plane.c+2 -20 replies
17/22drm/sprd: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/sprd/sprd_dpu.c drivers/gpu/drm/sprd/sprd_drm.c drivers/gpu/drm/sprd/sprd_dsi.c+0 -30 replies
18/22drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/sun4i/sun8i_dw_hdmi.c+1 -11 reply
19/22drm/tidss: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/tidss/tidss_crtc.c drivers/gpu/drm/tidss/tidss_drv.c drivers/gpu/drm/tidss/tidss_encoder.c +2 more+1 -50 replies
20/22drm/udl: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/udl/udl_drv.c drivers/gpu/drm/udl/udl_modeset.c+1 -20 replies
21/22drm/vboxvideo: Remove unnecessary include statements for drm_crtc_helper.hdrivers/gpu/drm/vboxvideo/vbox_drv.c drivers/gpu/drm/vboxvideo/vbox_main.c+1 -20 replies
22/22drm/crtc-helper: Remove most include statements from drm_crtc_helper.hinclude/drm/drm_crtc_helper.h+9 -50 replies

Reviews trailers per patch

3 of 22 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJani NikulaAlex DeucherSam Ravnborg
SeriesA-b A-b R-b
1/22
2/22R-b
3/22R-b
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22R-b
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies.

Where possible, remove the include statements for drm_crtc_helper.h and include the required source files directly. Also remove the include statements from drm_crtc_helper.h itself, which doesn't need most of them.

I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.

Thanks to Sam Ravnborg for bringing this to my attention.

Thomas Zimmermann (22):
drm/amdgpu: Fix coding style
drm: Remove unnecessary include statements for drm_crtc_helper.h drm/amdgpu: Remove unnecessary include statements for
drm_crtc_helper.h
drm/arm/komeda: Remove unnecessary include statements for
drm_crtc_helper.h
drm/aspeed: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ast: Remove unnecessary include statements for drm_crtc_helper.h drm/bridge: Remove unnecessary include statements for
drm_crtc_helper.h
drm/gma500: Remove unnecessary include statements for
drm_crtc_helper.h
drm/i2c/ch7006: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ingenic: Remove unnecessary include statements for
drm_crtc_helper.h
drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h drm/logicvc: Remove unnecessary include statements for
drm_crtc_helper.h
drm/nouveau: Remove unnecessary include statements for
drm_crtc_helper.h
drm/radeon: Remove unnecessary include statements for
drm_crtc_helper.h
drm/rockchip: Remove unnecessary include statements for
drm_crtc_helper.h
drm/shmobile: Remove unnecessary include statements for
drm_crtc_helper.h
drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h drm/udl: Remove unnecessary include statements for drm_crtc_helper.h drm/vboxvideo: Remove unnecessary include statements for
drm_crtc_helper.h
drm/crtc-helper: Remove most include statements from drm_crtc_helper.h

 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c     |  2 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c         |  5 +++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c        |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c       |  1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c            |  1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h           |  1 -
 drivers/gpu/drm/amd/amdgpu/atombios_crtc.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c     |  1 -
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c             |  2 ++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c             |  2 ++
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c              |  2 ++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c              |  2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_crtc.c   |  1 -
 drivers/gpu/drm/arm/display/komeda/komeda_kms.h    |  1 -
 drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c           |  1 -
 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c            |  1 -
 drivers/gpu/drm/aspeed/aspeed_gfx_out.c            |  1 -
 drivers/gpu/drm/ast/ast_drv.c                      |  1 -
 drivers/gpu/drm/ast/ast_main.c                     |  1 -
 drivers/gpu/drm/ast/ast_mode.c                     |  1 -
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c |  1 -
 drivers/gpu/drm/bridge/analogix/anx7625.c          |  1 -
 .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c    |  1 -
 drivers/gpu/drm/bridge/ite-it6505.c                |  1 -
 drivers/gpu/drm/bridge/ite-it66121.c               |  1 -
 drivers/gpu/drm/bridge/tc358768.c                  |  1 -
 drivers/gpu/drm/bridge/tc358775.c                  |  1 -
 drivers/gpu/drm/drm_crtc_helper.c                  |  1 -
 drivers/gpu/drm/drm_lease.c                        |  2 +-
 drivers/gpu/drm/drm_plane_helper.c                 |  1 -
 drivers/gpu/drm/gma500/cdv_device.c                |  1 +
 drivers/gpu/drm/gma500/cdv_intel_crt.c             |  2 ++
 drivers/gpu/drm/gma500/cdv_intel_display.c         |  1 +
 drivers/gpu/drm/gma500/cdv_intel_dp.c              |  1 +
 drivers/gpu/drm/gma500/cdv_intel_hdmi.c            |  2 ++
 drivers/gpu/drm/gma500/cdv_intel_lvds.c            |  2 ++
 drivers/gpu/drm/gma500/framebuffer.c               |  2 ++
 drivers/gpu/drm/gma500/gma_display.c               |  2 ++
 drivers/gpu/drm/gma500/oaktrail_crtc.c             |  1 +
 drivers/gpu/drm/gma500/oaktrail_hdmi.c             |  2 ++
 drivers/gpu/drm/gma500/oaktrail_lvds.c             |  1 +
 drivers/gpu/drm/gma500/psb_device.c                |  1 +
 drivers/gpu/drm/gma500/psb_intel_display.c         |  3 +++
 drivers/gpu/drm/gma500/psb_intel_drv.h             |  1 -
 drivers/gpu/drm/gma500/psb_intel_lvds.c            |  2 ++
 drivers/gpu/drm/gma500/psb_intel_sdvo.c            |  2 ++
 drivers/gpu/drm/i2c/ch7006_drv.c                   |  2 ++
 drivers/gpu/drm/i2c/ch7006_priv.h                  |  1 -
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c          |  1 -
 drivers/gpu/drm/kmb/kmb_crtc.c                     |  1 -
 drivers/gpu/drm/kmb/kmb_plane.c                    |  1 -
 drivers/gpu/drm/logicvc/logicvc_interface.c        |  1 -
 drivers/gpu/drm/logicvc/logicvc_mode.c             |  1 -
 drivers/gpu/drm/nouveau/dispnv04/crtc.c            |  1 +
 drivers/gpu/drm/nouveau/dispnv04/dac.c             |  2 +-
 drivers/gpu/drm/nouveau/dispnv04/dfp.c             |  2 +-
 drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c     |  1 -
 drivers/gpu/drm/nouveau/dispnv04/tvnv04.c          |  2 +-
 drivers/gpu/drm/nouveau/dispnv04/tvnv17.c          |  1 +
 drivers/gpu/drm/nouveau/dispnv50/head.c            |  1 -
 drivers/gpu/drm/nouveau/nouveau_drm.c              |  1 -
 drivers/gpu/drm/nouveau/nouveau_vga.c              |  1 -
 drivers/gpu/drm/radeon/atombios_crtc.c             |  2 +-
 drivers/gpu/drm/radeon/atombios_encoders.c         |  1 +
 drivers/gpu/drm/radeon/r300.c                      |  1 -
 drivers/gpu/drm/radeon/radeon_asic.c               |  1 -
 drivers/gpu/drm/radeon/radeon_connectors.c         |  1 +
 drivers/gpu/drm/radeon/radeon_display.c            |  1 +
 drivers/gpu/drm/radeon/radeon_drv.c                |  1 -
 drivers/gpu/drm/radeon/radeon_encoders.c           |  1 -
 drivers/gpu/drm/radeon/radeon_irq_kms.c            |  1 -
 drivers/gpu/drm/radeon/radeon_legacy_crtc.c        |  2 +-
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c    |  2 +-
 drivers/gpu/drm/radeon/radeon_legacy_tv.c          |  1 -
 drivers/gpu/drm/radeon/radeon_mode.h               |  2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c       |  1 -
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c          |  2 ++
 drivers/gpu/drm/shmobile/shmob_drm_drv.c           |  1 -
 drivers/gpu/drm/shmobile/shmob_drm_plane.c         |  1 -
 drivers/gpu/drm/sprd/sprd_dpu.c                    |  1 -
 drivers/gpu/drm/sprd/sprd_drm.c                    |  1 -
 drivers/gpu/drm/sprd/sprd_dsi.c                    |  1 -
 drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c              |  2 +-
 drivers/gpu/drm/tidss/tidss_crtc.c                 |  1 -
 drivers/gpu/drm/tidss/tidss_drv.c                  |  1 -
 drivers/gpu/drm/tidss/tidss_encoder.c              |  2 +-
 drivers/gpu/drm/tidss/tidss_kms.c                  |  1 -
 drivers/gpu/drm/tidss/tidss_plane.c                |  1 -
 drivers/gpu/drm/udl/udl_drv.c                      |  2 +-
 drivers/gpu/drm/udl/udl_modeset.c                  |  1 -
 drivers/gpu/drm/vboxvideo/vbox_drv.c               |  2 +-
 drivers/gpu/drm/vboxvideo/vbox_main.c              |  1 -
 include/drm/drm_crtc_helper.h                      | 14 +++++++++-----
 include/drm/drm_fixed.h                            |  1 +
 94 files changed, 70 insertions(+), 70 deletions(-)

base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6

Signature · 1 line
2.39.0