Skip to content

md/bitmap: Optimal last page size

Jonathan Derrick linux-raid 5 versions – Applied

Status from this message: Applied to md-next. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 8 repliesApplied
  2. v43 patches 1 replySuperseded
  3. v33 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch6 repliesSuperseded
v11 patch6 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3md: Move sb writer loop to its own functiondrivers/md/md-bitmap.c+65 -600 replies
2/3md: Fix types in sb writerdrivers/md/md-bitmap.c+14 -210 replies
3/3md: Use optimal I/O size for last bitmap pagedrivers/md/md-bitmap.c+29 -47 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigXiao Ni
SeriesT-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] md/bitmap: Optimal last page size

From: Jon Derrick <[email protected]>

Currently the last bitmap page write will size itself down to the logical block size. This could cause less performance for devices which have atomic write units larger than the block size, such as many NVMe devices with 4kB write units and 512B block sizes. There is usually a large amount of space after the bitmap and using the optimal I/O size could favor speed over size.

This was tested on an Intel/Solidigm P5520 drive with lba format 512B, optimal I/O size of 4kB, resulting in a > 10x IOPS increase.

See patch 3 log for results.

v4->v5: Initialized rdev (kernel test bot)
v3->v4: Fixed reviewers concerns
v2->v3: Prep patch added and types fixed
Added helpers for optimal I/O sizes

Jon Derrick (3):
md: Move sb writer loop to its own function
md: Fix types in sb writer
md: Use optimal I/O size for last bitmap page

 drivers/md/md-bitmap.c | 143 ++++++++++++++++++++++++-----------------
 1 file changed, 83 insertions(+), 60 deletions(-)
Signature · 1 line
2.27.0