Skip to content

PCI/AER: Remove redundant Device Control Error Reporting Enable

Bjorn Helgaas intel-wired-lan linux-pci lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9PCI/AER: Remove redundant Device Control Error Reporting Enabledrivers/pci/pcie/aer.c+0 -482 replies
2/9e1000e: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/e1000e/netdev.c+0 -76 replies
3/9fm10k: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/fm10k/fm10k_pci.c+0 -51 reply
4/9i40e: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/i40e/i40e_main.c+0 -42 replies
5/9iavf: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/iavf/iavf_main.c+0 -52 replies
6/9ice: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/ice/ice_main.c+0 -32 replies
7/9igb: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/igb/igb_main.c+0 -52 replies
8/9igc: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/igc/igc_main.c+0 -52 replies
9/9ixgbe: Remove redundant pci_enable_pcie_error_reporting()drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+0 -52 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchKuppuswamy SathyanarayananTony NguyenStefan RoeseNaama MeirGurucharan GMarek Szlosek
1/9R-b R-b
2/9R-b
3/9R-b
4/9R-b T-b
5/9R-b T-b
6/9R-b T-b
7/9R-b T-b
8/9R-b T-b
9/9R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable

From: Bjorn Helgaas <[email protected]>

Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), ths PCI core sets the Device Control bits that enable error reporting for PCIe devices.

This series removes redundant calls to pci_enable_pcie_error_reporting() that do the same thing from the AER driver and several NIC drivers.

There are several more drivers where this should be removed; I started with just the Intel drivers here.

Bjorn Helgaas (9):
PCI/AER: Remove redundant Device Control Error Reporting Enable
e1000e: Remove redundant pci_enable_pcie_error_reporting()
fm10k: Remove redundant pci_enable_pcie_error_reporting()
i40e: Remove redundant pci_enable_pcie_error_reporting()
iavf: Remove redundant pci_enable_pcie_error_reporting()
ice: Remove redundant pci_enable_pcie_error_reporting()
igb: Remove redundant pci_enable_pcie_error_reporting()
igc: Remove redundant pci_enable_pcie_error_reporting()
ixgbe: Remove redundant pci_enable_pcie_error_reporting()

 drivers/net/ethernet/intel/e1000e/netdev.c    |  7 ---
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  |  5 --
 drivers/net/ethernet/intel/i40e/i40e_main.c   |  4 --
 drivers/net/ethernet/intel/iavf/iavf_main.c   |  5 --
 drivers/net/ethernet/intel/ice/ice_main.c     |  3 --
 drivers/net/ethernet/intel/igb/igb_main.c     |  5 --
 drivers/net/ethernet/intel/igc/igc_main.c     |  5 --
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 --
 drivers/pci/pcie/aer.c                        | 48 -------------------
 9 files changed, 87 deletions(-)
Signature · 1 line
2.25.1