Skip to content

Mdmonitor refactor and udev event handling improvements

Mateusz Grzonka linux-raid 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesIn review
  2. v38 patches 11 repliesSuperseded
  3. v28 patches 0 repliesSuperseded

Changes in v4 from the cover letter

Fix building errors. Only two last patches out of 8 didn't apply, so I'm sending just them.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Mdmonitor: Improve udev event handlingMakefile Manage.c Monitor.c +5 more+252 -1143 replies
2/2udev: Move udev_block() and udev_unblock() into udev.cCreate.c lib.c mdadm.h +3 more+54 -370 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] Mdmonitor refactor and udev event handling improvements

Along the way we observed many problems with current approach to event handling in mdmonitor. It frequently doesn't report Fail and DeviceDisappeared events.
It's due to time races with udev, and too long delay in some cases.
While there was a patch intending to address time races with udev, it didn't remove them completely. This patch series presents alternative approach, where mdmonitor wakes up on udev events, so that there should be no more conflicts with udev we saw before.

Additionally some code quality improvements were done, to make the code more maintainable.

v2:
Fixed mismatched comment style and rebased onto master.

v3:
Resend to cleanup on patchwork.

v4:
Fix building errors. Only two last patches out of 8 didn't apply, so I'm sending just them.

Mateusz Grzonka (2):
Mdmonitor: Improve udev event handling
udev: Move udev_block() and udev_unblock() into udev.c

 Create.c  |   1 +
 Makefile  |  18 ++---
 Manage.c  |   3 +-
 Monitor.c | 137 ++++++++++++++------------------------
 lib.c     |  42 ------------
 mdadm.h   |   3 -
 mdopen.c  |  19 +++---
 udev.c    | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 udev.h    |  40 +++++++++++
 9 files changed, 306 insertions(+), 151 deletions(-)
 create mode 100644 udev.c
 create mode 100644 udev.h
Signature · 1 line
2.26.2