Skip to content

Fixes and cleanup for DRM fbdev emulation and deferred I/O

Javier Martinez Canillas dri-devel linux-fbdev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Re-introduce the CONFIG_FB_DEFERRED_IO ifdef guard for the @fbdefio field declaration since the kernel test robot reported that's needed at the end.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fbdev: Remove unused struct fb_deferred_io .first_io fielddrivers/video/fbdev/core/fb_defio.c include/linux/fb.h+0 -51 reply
2/3drm/fb-helper: Check fb_deferred_io_init() return valuedrivers/gpu/drm/drm_fbdev_generic.c+3 -11 reply
3/3drm/fb-helper: Use a per-driver FB deferred I/O handlerdrivers/gpu/drm/drm_fbdev_generic.c include/drm/drm_fb_helper.h+17 -61 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchThomas Zimmermann
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fixes and cleanup for DRM fbdev emulation and deferred I/O

Hello,

This patch series contains two fixes and a cleanup for things that I noticed while debugging a regression in the fbdev emulation for a DRM driver.

The first two patches are trivial and shoulnd't be controversial, the third patch is less trivial, but it has been already reviewed by Thomas and I did test it to make sure that works as expected. With it, I got rid of the WARN that happened due a mutex used after it has been destroyed.

Best regards,
Javier

Changes in v2:
- Re-introduce the CONFIG_FB_DEFERRED_IO ifdef guard for the @fbdefio field declaration since the kernel test robot reported that's needed at the end.

Javier Martinez Canillas (3):
fbdev: Remove unused struct fb_deferred_io .first_io field drm/fb-helper: Check fb_deferred_io_init() return value drm/fb-helper: Use a per-driver FB deferred I/O handler

 drivers/gpu/drm/drm_fbdev_generic.c | 15 ++++++++-------
 drivers/video/fbdev/core/fb_defio.c |  4 ----
 include/drm/drm_fb_helper.h         | 12 ++++++++++++
 include/linux/fb.h                  |  1 -
 4 files changed, 20 insertions(+), 12 deletions(-)
Signature · 1 line
2.39.0