perf symbols: Improve dso__synthesize_plt_symbols()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | perf test: Add Symbols testtools/ tools/ tools/ +2 more | +160 | 0 replies | |
| 2/10 | perf symbols: Factor out get_plt_sizes()tools/ | +28 | 0 replies | |
| 3/10 | perf symbols: Check plt_entry_size is not zerotools/ | +11 | 0 replies | |
| 4/10 | perf symbols: Add dso__find_symbol_nocache()tools/ tools/ | +6 | 0 replies | |
| 5/10 | perf symbols: Slightly simplify 'err' usage in dso__synthesize_plt_symbols()tools/ | +3 | 0 replies | |
| 6/10 | perf symbols: Do not check ss->dynsym twicetools/ | +0 | 0 replies | |
| 7/10 | perf symbols: Add symbol for .plt headertools/ | +21 | 0 replies | |
| 8/10 | perf symbols: Allow for .plt entries with no symboltools/ | +10 | 0 replies | |
| 9/10 | perf symbols: Combine handling for SHT_RELA and SHT_RELtools/ | +27 | 0 replies | |
| 10/10 | perf symbols: Check SHT_RELA and SHT_REL type earliertools/ | +27 | 0 replies |
Reviews trailers per patch
None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ian Rogers |
|---|---|
| Series | A-b |
| 1/10 | |
| 2/10 | |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] perf symbols: Improve dso__synthesize_plt_symbols()
Hi
This is the first of 2 patchsets to improve dso__synthesize_plt_symbols(). This patchset is really preparation for the 2nd patchset, which focuses on getting rid of unknown symbols that show up in Intel PT traces. The 2nd patchset is still under development.
These patches are small and staightforward. Only the new Symbols test is slightly interesting because it provides a way to see what symbols perf discovers for any given dso. The test fails initially, but should pass after patch 7 "perf symbols: Add symbol for .plt header".
Adrian Hunter (10):
perf test: Add Symbols test
perf symbols: Factor out get_plt_sizes()
perf symbols: Check plt_entry_size is not zero
perf symbols: Add dso__find_symbol_nocache()
perf symbols: Slightly simplify 'err' usage in dso__synthesize_plt_symbols() perf symbols: Do not check ss->dynsym twice
perf symbols: Add symbol for .plt header
perf symbols: Allow for .plt entries with no symbol
perf symbols: Combine handling for SHT_RELA and SHT_REL
perf symbols: Check SHT_RELA and SHT_REL type earlier
tools/perf/Documentation/perf-test.txt | 3 + tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 3 + tools/perf/tests/symbols.c | 150 ++++++++++++++++++++++++++ tools/perf/tests/tests.h | 3 + tools/perf/util/symbol-elf.c | 190 +++++++++++++++++---------------- tools/perf/util/symbol.c | 5 + tools/perf/util/symbol.h | 1 + 8 files changed, 262 insertions(+), 94 deletions(-) create mode 100644 tools/perf/tests/symbols.c
Regards
Adrian