Skip to content

tests/avocado: Pass parameters via Makefile

Fabiano Rosas qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/avocado: Invert parameter vs. tag precedence during setUptests/avocado/avocado_qemu/__init__.py+19 -131 reply
2/2tests/avocado: Allow passing command line parameters via Makefiletests/Makefile.include+5 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDaniel Henrique Barboza
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] tests/avocado: Pass parameters via Makefile

This is intended to replace the last two patches of Daniel's series:
https://lore.kernel.org/r/[email protected]

Currently, the initialization code in setUp() infers properties of the tests & host/target machine by looking at the avocado tags present in the test. If there are no tags some best-effort fallbacks are chosen.

This means that for generic tests they end up always choosing the QEMU target that matches the host architecture, which is not always desirable. If we allow command line parameters to override the fallback, we can alter this behavior.

patch 1 - change precedence to tags > params to avoid changing tests

          that do have tags;

patch 2 - wires up the new AVOCADO_PARAMS variable to the '-p' avocado

          command line option;

Fabiano Rosas (2):
tests/avocado: Invert parameter vs. tag precedence during setUp tests/avocado: Allow passing command line parameters via Makefile

 tests/Makefile.include                 |  6 ++++-
 tests/avocado/avocado_qemu/__init__.py | 32 +++++++++++++++-----------
 2 files changed, 24 insertions(+), 14 deletions(-)
Signature · 1 line
2.35.3