Skip to content

Allow easy re-running of grub-shell from failed tests

Glenn Washburn grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests: Allow turning on shell tracing from environment variablestests/util/grub-fs-tester.in tests/util/grub-shell.in+6 -10 replies
2/3grub-shell: Create run.sh in working directory for easily running test againtests/util/grub-shell.in+23 -50 replies
3/3grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU argumentstests/util/grub-shell.in+5 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Allow easy re-running of grub-shell from failed tests

When a non-native (eg. grub-shell/qemu) test fails it can be useful to be able to re-run the grub-shell invocation in at least two circumstances.

1. The tester wants to re-run the grub-shell invocation with extra args so that QEMU starts in GDB attach mode for using GDB to debug the test case
2. For a tester who wants to send a failed test case to another developer for additional debugging. It would be nice to be able to just zip/tar just the failed test case test output directory and allow the extracted directory to easily run the failed test case again. The results in this case still might not be the same if the sender and reciever do not have the same QEMU. Though when the QMEU versions are different, I expect the emulated execution on sender and reciever to be close enough to produce the same execution path (maybe not with super old QEMUs, but I don't think its something to be concerned about).

The first patch is needed to make the other two useful. Without it, I know of no easy way to enable grub-shell's debug mode when run via make check. And if grub-shell is not in debug mode then it will remove most/all of the generated files, which would prevent debugging.

Glenn

Glenn Washburn (3):
tests: Allow turning on shell tracing from environment variables
grub-shell: Create run.sh in working directory for easily running test
again
grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial
QEMU arguments

 tests/util/grub-fs-tester.in |  2 ++
 tests/util/grub-shell.in     | 37 +++++++++++++++++++++++++++++-------
 2 files changed, 32 insertions(+), 7 deletions(-)
Signature · 1 line
2.34.1