Skip to content

e2fsprogs: misc fixes, and add a GitHub Actions file

Eric Biggers linux-ext4 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest38 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/38configure.ac: only use Windows I/O manager on native Windowsconfigure.ac+1 -10 replies
2/38configure.ac: disable tdb by default on Windowsconfigure.ac+24 -80 replies
3/38configure.ac: automatically add include/mingw/ headersconfigure.ac+16 -00 replies
4/38configure: regenerateaclocal.m4 configure lib/config.h.in+262 -1230 replies
5/38config/install-sh: update to latest versionconfig/install-sh+493 -1900 replies
6/38lib, misc: eliminate dependency on Winsockinclude/mingw/arpa/inet.h lib/e2p/Android.bp lib/ext2fs/Android.bp +3 more+5 -120 replies
7/38lib/blkid: remove 32-bit x86 byteswap assemblylib/blkid/probe.h+0 -431 reply
8/38lib/blkid: fix unaligned access to hfs_mdblib/blkid/probe.c+4 -60 replies
9/38lib/blkid: fix -Wunused-variable warning in blkid_get_dev_size()lib/blkid/Android.bp lib/blkid/getsize.c+1 -20 replies
10/38lib/blkid: suppress -Wunused-result warning in blkid_flush_cache()lib/blkid/save.c+8 -00 replies
11/38lib/blkid: suppress -Wstringop-truncation warning in blkid_strndup()lib/blkid/devno.c+10 -00 replies
12/38lib/e2p: fix a -Wunused-variable warning in getflags()lib/e2p/getflags.c+2 -10 replies
13/38lib/{e2p,ss}: remove manual declarations of errnolib/e2p/fgetversion.c lib/e2p/fsetversion.c lib/e2p/getversion.c +4 more+0 -110 replies
14/38lib/et: fix "unused variable" warnings when !HAVE_FCNTLlib/et/Android.bp lib/et/error_message.c+5 -80 replies
15/38lib/ext2fs: remove 32-bit x86 bitops assemblylib/ext2fs/bitops.c lib/ext2fs/bitops.h+2 -1090 replies
16/38lib/ext2fs: consistently use #ifdefs in ext2fs_print_bmap_statistics()lib/ext2fs/gen_bitmap64.c+2 -40 replies
17/38lib/ext2fs: remove unused variable in ext2fs_xattrs_read_inode()lib/ext2fs/ext_attr.c+0 -20 replies
18/38lib/ext2fs: fix a printf format specifier in file_test()lib/ext2fs/inline_data.c+1 -10 replies
19/38lib/ext2fs: fix two compiler warnings in windows_io.clib/ext2fs/windows_io.c+1 -110 replies
20/38lib/ext2fs: fix a -Wpointer-sign warning in ext2fs_mmp_start()lib/ext2fs/mmp.c+1 -10 replies
21/38lib/{ext2fs,support}: fix 32-bit Windows buildlib/ext2fs/getsectsize.c lib/support/plausible.c util/subst.c+9 -90 replies
22/38lib/ss: fix 'make install' by creating man1dirlib/ss/Makefile.in+3 -20 replies
23/38lib/support: remove unused label in get_devname()lib/support/devname.c+0 -10 replies
24/38lib/support: clean up definition of flags_arraylib/support/print_fs_flags.c+30 -300 replies
25/38lib/uuid: remove conflicting Windows implementation of gettimeofday()lib/uuid/gen_uuid.c+0 -210 replies
26/38e2fsck: use real functions for kernel slab functionse2fsck/jfs_user.h+45 -170 replies
27/38misc/create_inode: fix -Wunused-variable warnings in __populate_fs()misc/create_inode.c+6 -40 replies
28/38misc/create_inode: simplify logic in scandir()misc/create_inode.c+10 -160 replies
29/38misc/e4defrag: fix -Wstringop-truncation warningsmisc/e4defrag.c+9 -210 replies
30/38misc/fuse2fs: avoid error-prone strncpy() patternmisc/fuse2fs.c+3 -20 replies
31/38misc/mk_hugefiles: simplify get_partition_start()include/mingw/sys/sysmacros.h misc/mk_hugefiles.c+10 -1320 replies
32/38misc/mke2fs: fix Windows buildlib/ext2fs/ext2_io.h lib/support/plausible.c misc/mke2fs.c+9 -120 replies
33/38misc/mke2fs: fix a -Wunused-variable warning in PRS()misc/mke2fs.c+6 -40 replies
34/38misc/tune2fs: fix setting fsuuid::fsu_lenmisc/tune2fs.c+1 -10 replies
35/38misc/tune2fs: fix -Wunused-variable warnings in handle_fslabel()misc/tune2fs.c+3 -20 replies
36/38misc/util.c: enable MinGW alarm() when building for Windowsmisc/Android.bp misc/util.c+5 -20 replies
37/38resize2fs: remove unused variable from adjust_superblock()resize/resize2fs.c+0 -40 replies
38/38Add a configuration file for GitHub Actions.github/workflows/ci.yml+116 -00 replies

Reviews trailers per patch

7 of 38 patches have a Reviewed-by or Acked-by.

PatchLukas CzernerJeremy BongioAndreas Dilger
1/38
2/38
3/38
4/38
5/38
6/38
7/38R-b
8/38
9/38
10/38
11/38
12/38
13/38
14/38
15/38
16/38R-b
17/38R-b
18/38
19/38
20/38
21/38
22/38
23/38R-b
24/38R-b
25/38
26/38
27/38
28/38
29/38
30/38
31/38
32/38
33/38
34/38R-b R-b
35/38
36/38
37/38R-b
38/38

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/38] e2fsprogs: misc fixes, and add a GitHub Actions file

The last patch of this series adds a workflow file for GitHub Actions that builds and tests e2fsprogs on Ubuntu, macOS, and Windows. It's enforced that the build does not produce warnings with -Wall.

(For now, the Windows build is much more basic than the others; only mke2fs is built, and the unit tests are not run.)

The workflow will run on pushes to any fork of e2fsprogs that has GitHub Actions enabled. I'm hoping that Ted will enable it for the "official" fork at https://github.com/tytso/e2fsprogs, but anyone can use it in their own fork too. The results for this patch series are at
https://github.com/ebiggers/e2fsprogs/actions/runs/3976382057

As a prerequisite to actually getting everything to pass, patches 1-37 of this series fix a large number of miscellaneous issues, mainly pertaining to warnings with -Wall or to the Windows build.

Some patches in this series I've already sent out individually. This series supersedes all my previous patches.

Eric Biggers (38):
configure.ac: only use Windows I/O manager on native Windows configure.ac: disable tdb by default on Windows configure.ac: automatically add include/mingw/ headers
configure: regenerate
config/install-sh: update to latest version
lib, misc: eliminate dependency on Winsock
lib/blkid: remove 32-bit x86 byteswap assembly
lib/blkid: fix unaligned access to hfs_mdb
lib/blkid: fix -Wunused-variable warning in blkid_get_dev_size() lib/blkid: suppress -Wunused-result warning in blkid_flush_cache() lib/blkid: suppress -Wstringop-truncation warning in blkid_strndup() lib/e2p: fix a -Wunused-variable warning in getflags() lib/{e2p,ss}: remove manual declarations of errno
lib/et: fix "unused variable" warnings when !HAVE_FCNTL lib/ext2fs: remove 32-bit x86 bitops assembly
lib/ext2fs: consistently use #ifdefs in ext2fs_print_bmap_statistics() lib/ext2fs: remove unused variable in ext2fs_xattrs_read_inode() lib/ext2fs: fix a printf format specifier in file_test() lib/ext2fs: fix two compiler warnings in windows_io.c lib/ext2fs: fix a -Wpointer-sign warning in ext2fs_mmp_start() lib/{ext2fs,support}: fix 32-bit Windows build
lib/ss: fix 'make install' by creating man1dir lib/support: remove unused label in get_devname() lib/support: clean up definition of flags_array
lib/uuid: remove conflicting Windows implementation of gettimeofday()
e2fsck: use real functions for kernel slab functions misc/create_inode: fix -Wunused-variable warnings in __populate_fs() misc/create_inode: simplify logic in scandir() misc/e4defrag: fix -Wstringop-truncation warnings misc/fuse2fs: avoid error-prone strncpy() pattern misc/mk_hugefiles: simplify get_partition_start() misc/mke2fs: fix Windows build
misc/mke2fs: fix a -Wunused-variable warning in PRS() misc/tune2fs: fix setting fsuuid::fsu_len
misc/tune2fs: fix -Wunused-variable warnings in handle_fslabel() misc/util.c: enable MinGW alarm() when building for Windows
resize2fs: remove unused variable from adjust_superblock() Add a configuration file for GitHub Actions

 .github/workflows/ci.yml      | 116 ++++++
 aclocal.m4                    | 180 +++++----
 config/install-sh             | 683 ++++++++++++++++++++++++----------
 configure                     | 105 ++++--
 configure.ac                  |  50 ++-
 e2fsck/jfs_user.h             |  62 ++-
 include/mingw/arpa/inet.h     |   5 +
 include/mingw/sys/sysmacros.h |   8 +-
 lib/blkid/Android.bp          |   1 -
 lib/blkid/devno.c             |  10 +
 lib/blkid/getsize.c           |   2 +-
 lib/blkid/probe.c             |  10 +-
 lib/blkid/probe.h             |  43 ---
 lib/blkid/save.c              |   8 +
 lib/config.h.in               | 100 ++++-
 lib/e2p/Android.bp            |   4 -
 lib/e2p/fgetversion.c         |   2 -
 lib/e2p/fsetversion.c         |   1 -
 lib/e2p/getflags.c            |   3 +-
 lib/e2p/getversion.c          |   1 -
 lib/e2p/setversion.c          |   1 -
 lib/et/Android.bp             |   3 -
 lib/et/error_message.c        |  10 +-
 lib/ext2fs/Android.bp         |   2 -
 lib/ext2fs/bitops.c           |  14 +-
 lib/ext2fs/bitops.h           |  97 -----
 lib/ext2fs/ext2_io.h          |   2 +
 lib/ext2fs/ext_attr.c         |   2 -
 lib/ext2fs/gen_bitmap64.c     |   6 +-
 lib/ext2fs/getsectsize.c      |  12 +-
 lib/ext2fs/inline_data.c      |   2 +-
 lib/ext2fs/jfs_compat.h       |   4 -
 lib/ext2fs/mmp.c              |   2 +-
 lib/ext2fs/windows_io.c       |  12 +-
 lib/ss/Makefile.in            |   5 +-
 lib/ss/execute_cmd.c          |   2 -
 lib/ss/help.c                 |   2 -
 lib/ss/pager.c                |   2 -
 lib/support/devname.c         |   1 -
 lib/support/plausible.c       |   7 +-
 lib/support/print_fs_flags.c  |  60 +--
 lib/uuid/gen_uuid.c           |  21 --
 misc/Android.bp               |   3 -
 misc/create_inode.c           |  36 +-
 misc/e4defrag.c               |  30 +-
 misc/fuse2fs.c                |   5 +-
 misc/mk_hugefiles.c           | 134 +------
 misc/mke2fs.c                 |  22 +-
 misc/tune2fs.c                |   7 +-
 misc/util.c                   |   5 +
 resize/resize2fs.c            |   4 -
 util/android_config.h         |   1 -
 util/subst.c                  |   4 +-
 53 files changed, 1102 insertions(+), 812 deletions(-)
 create mode 100644 .github/workflows/ci.yml
 create mode 100644 include/mingw/arpa/inet.h

base-commit: aad34909b6648579f42dade5af5b46821aa4d845

Signature · 1 line
2.39.0