Skip to content

ACPI controller cleanup

Bernhard Beschow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hw/acpi/{ich9, piix4}: Reuse existing attributes for QOM propertieshw/acpi/ich9.c hw/acpi/piix4.c+6 -91 reply
2/7hw/acpi/ich9: Remove unneeded assignmentshw/acpi/ich9.c+1 -32 replies
3/7hw/acpi/{ich9, piix4}: Resolve redundant io_base address attributeshw/acpi/ich9.c hw/acpi/piix4.c include/hw/acpi/ich9.h +1 more+14 -174 replies
4/7hw/acpi/ich9: Use ICH9_PMIO_GPE0_STS just oncehw/acpi/ich9.c+3 -11 reply
5/7hw/acpi/piix4: Fix offset of GPE0 registershw/acpi/piix4.c include/hw/acpi/piix4.h+8 -23 replies
6/7hw/acpi: Trace GPE access in all device models, not just PIIX4hw/acpi/core.c hw/acpi/piix4.c hw/acpi/trace-events+9 -72 replies
7/7hw/acpi/core: Trace enable and status registers of GPE separatelyhw/acpi/core.c hw/acpi/trace-events+11 -51 reply

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéIgor Mammedov
1/7
2/7
3/7
4/7
5/7
6/7R-b R-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] ACPI controller cleanup

This series brings the PIIX4 PM device closer to reality and resolves some redundant code along the way.

Testing done:
- make check
- Starting a live CD under pc and q35 machines and check that the GPE accesses are traced

Bernhard Beschow (7):
hw/acpi/{ich9,piix4}: Reuse existing attributes for QOM properties hw/acpi/ich9: Remove unneeded assignments hw/acpi/{ich9,piix4}: Resolve redundant io_base address attributes hw/acpi/ich9: Use ICH9_PMIO_GPE0_STS just once hw/acpi/piix4: Fix offset of GPE0 registers
hw/acpi: Trace GPE access in all device models, not just PIIX4 hw/acpi/core: Trace enable and status registers of GPE separately

 include/hw/acpi/ich9.h  |  1 -
 include/hw/acpi/piix4.h |  3 +--
 hw/acpi/core.c          |  9 +++++++++
 hw/acpi/ich9.c          | 26 ++++++++++++--------------
 hw/acpi/piix4.c         | 31 ++++++++++++++++---------------
 hw/acpi/trace-events    | 10 ++++++----
 6 files changed, 44 insertions(+), 36 deletions(-)
Signature · 1 line
2.39.1