Skip to content

audio: make audiodev introspectable by management apps

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 8 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qapi, audio: add query-audiodev commandaudio/audio.c qapi/audio.json+25 -07 replies
2/2qapi, audio: Make introspection reflect build configuration more closelyaudio/audio.c audio/audio_legacy.c audio/audio_template.h +1 more+112 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] audio: make audiodev introspectable by management apps

Here's a respin from Daniel's audiodev introspection patches from 2021. I've rebased them to the current master branch and addressed the review comments from v1.

The Audiodev QAPI type is not introspectable via query-qmp-schema as nothing in QMP uses it. "-audiodev" is not introspectable via query-command-line-options because it avoided legacy QemuOpts.

To fix it, introduce a tiny "query-audiodev" QMP command that uses the "Audiodev" QAPI structure, so that it shows up in the schema. Then mark the various backend types with conditionals so that only the ones that were available at compile time show up in the schema.

Daniel P. Berrangé (2):
qapi, audio: add query-audiodev command
qapi, audio: Make introspection reflect build configuration more
closely

 qapi/audio.json        | 57 +++++++++++++++++++++++++++++++++---------
 audio/audio_template.h | 20 +++++++++++++++
 audio/audio.c          | 32 ++++++++++++++++++++++++
 audio/audio_legacy.c   | 41 +++++++++++++++++++++++++++++-
 4 files changed, 137 insertions(+), 13 deletions(-)
Signature · 1 line
2.31.1