Skip to content

staging: iio: accel: adis16203 Inclinometer cleanup and graduation

Jonathan Cameron linux-devicetree linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 4 repliesIn review
  2. v112 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Device tree binding docs fixes.
- --no-renames so that the whole driver is in the patch 11 email for easy review of what I am proposing we move out of staging.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12staging: iio: accel: adis16203: More conventional header orderingdrivers/staging/iio/accel/adis16203.c+3 -40 replies
2/12staging: iio: accel: adis16203: Drop excessive register commentsdrivers/staging/iio/accel/adis16203.c+1 -700 replies
3/12staging: iio: accel: adis16203: Rename incli channel registersdrivers/staging/iio/accel/adis16203.c+4 -40 replies
4/12staging: iio: accel: adis16203: Drop the 180 degree offset channeldrivers/staging/iio/accel/adis16203.c+1 -50 replies
5/12staging: iio: accel: adis16203: Simplify handling of calibbiasdrivers/staging/iio/accel/adis16203.c+10 -100 replies
6/12staging: iio: accel: adis16203: Drop driver name definedrivers/staging/iio/accel/adis16203.c+1 -30 replies
7/12staging: iio: accel: adis16203: Make units explicit in name of delay definedrivers/staging/iio/accel/adis16203.c+4 -40 replies
8/12staging: iio: accel: adis16203: Trivial whitespace cleanupdrivers/staging/iio/accel/adis16203.c+46 -510 replies
9/12staging: iio: accel: adis16203: Drop setting drvdata as nothing gets itdrivers/staging/iio/accel/adis16203.c+0 -20 replies
10/12staging: iio: accel: adis16203: Trivial style cleanupdrivers/staging/iio/accel/adis16203.c+1 -20 replies
11/12staging: iio: accel: adis16203: Move out of stagingdrivers/iio/accel/Kconfig drivers/iio/accel/Makefile drivers/iio/accel/adis16203.c +3 more+244 -2440 replies
12/12dt-bindings: iio: accel: Add ADIS16203 InclinometerDocumentation/devicetree/bindings/iio/accel/adi,adis16203.yaml+64 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/12] staging: iio: accel: adis16203 Inclinometer cleanup and graduation

From: Jonathan Cameron <[email protected]>

v2:
- Device tree binding docs fixes.
- --no-renames so that the whole driver is in the patch 11 email for easy review of what I am proposing we move out of staging.

Whilst taking a look at what we still have in staging, I noticed that this driver was (probably) only still there due to the need to define some ABI for the odd 180 degree offset channel (same as the other channel minus 180 degrees).

Rather than leaving the driver in staging for ever, let us just drop that channel and move on. The rest of the series is trivial driver cleanup.

Note this is only build tested, so would be great if people can take a good look. If anyone happens to have one of these that would be even better (they are still marked for production use more than 12 years after the driver was submitted).

There are lots of features we could support if anyone wanted to, but it should be functional for basic channel reading without the bells and whistles. I've tried to incorporate the relevant device tree bindings however (multiple interrupt lines, supplies and reset gpio).

Cc: Barry Song <[email protected]>
(mostly for comedy value, not expecting you to remember the driver :)

Jonathan Cameron (12):
staging: iio: accel: adis16203: More conventional header ordering
staging: iio: accel: adis16203: Drop excessive register comments
staging: iio: accel: adis16203: Rename incli channel registers
staging: iio: accel: adis16203: Drop the 180 degree offset channel
staging: iio: accel: adis16203: Simplify handling of calibbias
staging: iio: accel: adis16203: Drop driver name define
staging: iio: accel: adis16203: Make units explicit in name of delay
define
staging: iio: accel: adis16203: Trivial whitespace cleanup
staging: iio: accel: adis16203: Drop setting drvdata as nothing gets
it
staging: iio: accel: adis16203: Trivial style cleanup
staging: iio: accel: adis16203: Move out of staging
dt-bindings: iio: accel: Add ADIS16203 Inclinometer

 .../bindings/iio/accel/adi,adis16203.yaml     |  64 ++++
 drivers/iio/accel/Kconfig                     |  12 +
 drivers/iio/accel/Makefile                    |   1 +
 drivers/iio/accel/adis16203.c                 | 231 +++++++++++++
 drivers/staging/iio/accel/Kconfig             |  12 -
 drivers/staging/iio/accel/Makefile            |   1 -
 drivers/staging/iio/accel/adis16203.c         | 315 ------------------
 7 files changed, 308 insertions(+), 328 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
 create mode 100644 drivers/iio/accel/adis16203.c
 delete mode 100644 drivers/staging/iio/accel/adis16203.c
Signature · 1 line
2.39.1