Skip to content

udf: Fix couple of preallocation related bugs

Jan Kara linux-fsdevel stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22udf: Unify types in anchor block detectionfs/udf/lowlevel.c fs/udf/super.c fs/udf/udfdecl.h+8 -50 replies
2/22udf: Drop VARCONV supportfs/udf/balloc.c fs/udf/directory.c fs/udf/inode.c +6 more+14 -840 replies
3/22udf: Move incrementing of goal block directly into inode_getblk()fs/udf/inode.c+2 -70 replies
4/22udf: Factor out block mapping into udf_map_block()fs/udf/inode.c fs/udf/udfdecl.h+49 -220 replies
5/22udf: Use udf_bread() in udf_get_pblock_virt15()fs/udf/partition.c+2 -30 replies
6/22udf: Use udf_bread() in udf_load_vat()fs/udf/super.c+8 -50 replies
7/22udf: Do not call udf_block_map() on ICB filesfs/udf/symlink.c+7 -120 replies
8/22udf: Convert udf_symlink_filler() to use udf_bread()fs/udf/symlink.c+4 -70 replies
9/22udf: Fold udf_block_map() into udf_map_block()fs/udf/inode.c fs/udf/udfdecl.h+14 -250 replies
10/22udf: Pass mapping request into inode_getblk()fs/udf/inode.c+24 -360 replies
11/22udf: Add flag to disable block preallocationfs/udf/inode.c+11 -60 replies
12/22udf: Use udf_map_block() in udf_getblk()fs/udf/inode.c+9 -80 replies
13/22udf: Fold udf_getblk() into udf_bread()fs/udf/inode.c+20 -270 replies
14/22udf: Protect rename against modification of moved directoryfs/udf/namei.c+12 -20 replies
15/22udf: Push i_data_sem locking into udf_expand_file_adinicb()fs/udf/file.c fs/udf/inode.c+11 -180 replies
16/22udf: Push i_data_sem locking into udf_extend_file()fs/udf/inode.c+4 -50 replies
17/22udf: Simplify error handling in udf_file_write_iter()fs/udf/file.c+3 -70 replies
18/22udf: Protect truncate and file type conversion with invalidate_lockfs/udf/file.c fs/udf/inode.c+11 -60 replies
19/22udf: Allocate blocks on write page faultfs/udf/file.c fs/udf/inode.c fs/udf/udfdecl.h+61 -20 replies
20/22udf: Do not allocate blocks on page writebackfs/udf/inode.c+34 -120 replies
21/22udf: Fix file corruption when appending just after end of preallocated extentfs/udf/inode.c+11 -130 replies
22/22udf: Fix off-by-one error when discarding preallocationfs/udf/inode.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/22] udf: Fix couple of preallocation related bugs

Hello,

fsx has revealed a couple of bugs related to preallocation handling in UDF. Firstly, we were not properly cleaning up preallocation for files that were dirtied via mmap, secondly, we didn't discard preallocation in some cases when expanding file with a hole which later led to confusion and data corruption. As part of these changes we start allocating blocks on page fault time instead of at writeback time and we also cleanup block mapping interfaces in UDF.

The patches are based on top of my for_next branch:

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs for_next

I plan to queue these patches to my tree.

Honza