Move and clean up monitor command code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest32 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/32 | monitor: Drop unnecessary includesmonitor/ monitor/ monitor/ +3 more | +2 | 1 reply | |
| 2/32 | audio: Move HMP commands from monitor/ to audio/audio/ audio/ include/ +1 more | +87 | 0 replies | |
| 3/32 | char: Move HMP commands from monitor/ to chardev/chardev/ chardev/ monitor/ +1 more | +225 | 0 replies | |
| 4/32 | char: Factor out qmp_add_client() parts and move to chardev/chardev/ include/ monitor/ | +25 | 0 replies | |
| 5/32 | hmp: Drop redundant argument check from add_completion_option()monitor/ | +0 | 0 replies | |
| 6/32 | readline: Extract readline_add_completion_of() from monitorinclude/ monitor/ monitor/ +1 more | +41 | 0 replies | |
| 7/32 | hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.hinclude/ monitor/ monitor/ +1 more | +6 | 0 replies | |
| 8/32 | trace: Move HMP commands from monitor/ to trace/include/ monitor/ trace/ +1 more | +152 | 2 replies | |
| 9/32 | machine: Move QMP commands from monitor/ to hw/core/hw/ monitor/ | +144 | 0 replies | |
| 10/32 | machine: Move HMP commands from monitor/ to hw/core/hw/ monitor/ | +208 | 0 replies | |
| 11/32 | qom: Move HMP commands from monitor/ to qom/monitor/ monitor/ qom/ | +67 | 1 reply | |
| 12/32 | block: Factor out hmp_change_medium(), and move to block/monitor/block/ include/ monitor/ | +25 | 2 replies | |
| 13/32 | rocker: Move HMP commands from monitor to hw/net/rocker/hw/ hw/ monitor/ | +317 | 0 replies | |
| 14/32 | hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma()include/ monitor/ | +11 | 0 replies | |
| 15/32 | net: Move HMP commands from monitor to net/monitor/ monitor/ net/ +1 more | +143 | 0 replies | |
| 16/32 | net: Move hmp_info_network() to net-hmp-cmds.cinclude/ include/ monitor/ +3 more | +33 | 0 replies | |
| 17/32 | migration: Move HMP commands from monitor/ to migration/migration/ migration/ monitor/ +1 more | +808 | 1 reply | |
| 18/32 | migration: Move the QMP command from monitor/ to migration/migration/ monitor/ | +30 | 1 reply | |
| 19/32 | virtio: Move HMP commands from monitor/ to hw/virtio/hw/ hw/ monitor/ | +322 | 1 reply | |
| 20/32 | tpm: Move HMP commands from monitor/ to softmmu/MAINTAINERS monitor/ softmmu/ +1 more | +67 | 1 reply | |
| 21/32 | runstate: Move HMP commands from monitor/ to softmmu/MAINTAINERS include/ monitor/ +3 more | +86 | 0 replies | |
| 22/32 | stats: Move QMP commands from monitor/ to stats/MAINTAINERS accel/ include/ +4 more | +170 | 0 replies | |
| 23/32 | stats: Move HMP commands from monitor/ to stats/monitor/ stats/ stats/ | +248 | 0 replies | |
| 24/32 | acpi: Move the QMP command from monitor/ to hw/acpi/hw/ hw/ monitor/ | +31 | 1 reply | |
| 25/32 | qdev: Move HMP command completion from monitor to softmmu/monitor/ softmmu/ | +82 | 0 replies | |
| 26/32 | monitor: Split file descriptor passing stuff off misc.cmonitor/ monitor/ monitor/ | +469 | 0 replies | |
| 27/32 | monitor: Move monitor_putc() next to monitor_puts & external linkageinclude/ monitor/ monitor/ | +28 | 0 replies | |
| 28/32 | monitor: Move target-dependent HMP commands to hmp-cmds-target.cinclude/ monitor/ monitor/ +1 more | +388 | 0 replies | |
| 29/32 | monitor: Move remaining HMP commands from misc.c to hmp-cmds.chmp-commands.hx include/ monitor/ +1 more | +233 | 0 replies | |
| 30/32 | monitor: Move remaining QMP stuff from misc.c to qmp-cmds.cmonitor/ monitor/ | +52 | 0 replies | |
| 31/32 | monitor: Loosen coupling between misc.c and monitor.c slightlymonitor/ monitor/ storage-daemon/ | +4 | 0 replies | |
| 32/32 | monitor: Rename misc.c to hmp-target.cmonitor/ monitor/ | +2 | 0 replies |
Reviews trailers per patch
9 of 32 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Stefan Hajnoczi | Stefan Berger | Juan Quintela |
|---|---|---|---|---|
| 1/32 | R-b | |||
| 2/32 | ||||
| 3/32 | ||||
| 4/32 | ||||
| 5/32 | ||||
| 6/32 | ||||
| 7/32 | ||||
| 8/32 | R-b | R-b | ||
| 9/32 | ||||
| 10/32 | ||||
| 11/32 | R-b | |||
| 12/32 | R-b | R-b | ||
| 13/32 | ||||
| 14/32 | ||||
| 15/32 | ||||
| 16/32 | ||||
| 17/32 | R-b | |||
| 18/32 | R-b | |||
| 19/32 | R-b | |||
| 20/32 | R-b | |||
| 21/32 | ||||
| 22/32 | ||||
| 23/32 | ||||
| 24/32 | R-b | |||
| 25/32 | ||||
| 26/32 | ||||
| 27/32 | ||||
| 28/32 | ||||
| 29/32 | ||||
| 30/32 | ||||
| 31/32 | ||||
| 32/32 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/32] Move and clean up monitor command code
Over the years, many commands got dumped into monitor/, where MAINTAINERS blames them on Dave and me. Recent "[PATCH v2 00/13] pci:
Move and clean up monitor command code" (merge commit 33698d3abf8) evicted commands related to PCI (qapi/pci.json), and "[PATCH v4 00/17]
ui: Move and clean up monitor command code" (merge commit 70d17c3eede) evicted commands rated to UI (qapi/ui.json) This series evicts most of the rest. Commands related to the monitor itself (qapi/control.json qapi/introspect.json) and miscellaneous commands (qapi/misc.json) stay in monitor/.
Together, these patches move almost 4000 lines from monitor/ to subsystems where they belong.
Based-on: <[email protected]>
Markus Armbruster (32):
monitor: Drop unnecessary includes
audio: Move HMP commands from monitor/ to audio/
char: Move HMP commands from monitor/ to chardev/
char: Factor out qmp_add_client() parts and move to chardev/
hmp: Drop redundant argument check from add_completion_option()
readline: Extract readline_add_completion_of() from monitor
hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.h
trace: Move HMP commands from monitor/ to trace/
machine: Move QMP commands from monitor/ to hw/core/
machine: Move HMP commands from monitor/ to hw/core/
qom: Move HMP commands from monitor/ to qom/
block: Factor out hmp_change_medium(), and move to block/monitor/
rocker: Move HMP commands from monitor to hw/net/rocker/
hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma()
net: Move HMP commands from monitor to net/
net: Move hmp_info_network() to net-hmp-cmds.c
migration: Move HMP commands from monitor/ to migration/
migration: Move the QMP command from monitor/ to migration/
virtio: Move HMP commands from monitor/ to hw/virtio/
tpm: Move HMP commands from monitor/ to softmmu/
runstate: Move HMP commands from monitor/ to softmmu/
stats: Move QMP commands from monitor/ to stats/
stats: Move HMP commands from monitor/ to stats/
acpi: Move the QMP command from monitor/ to hw/acpi/
qdev: Move HMP command completion from monitor to softmmu/
monitor: Split file descriptor passing stuff off misc.c
monitor: Move monitor_putc() next to monitor_puts & external linkage
monitor: Move target-dependent HMP commands to hmp-cmds-target.c
monitor: Move remaining HMP commands from misc.c to hmp-cmds.c
monitor: Move remaining QMP stuff from misc.c to qmp-cmds.c
monitor: Loosen coupling between misc.c and monitor.c slightly
monitor: Rename misc.c to hmp-target.c
MAINTAINERS | 10 +-
meson.build | 1 +
include/monitor/hmp-target.h | 6 +
include/monitor/hmp.h | 27 +
include/monitor/monitor.h | 1 +
include/monitor/qmp-helpers.h | 3 +
include/net/net.h | 4 +-
include/qemu/readline.h | 2 +
include/{monitor => sysemu}/stats.h | 0
monitor/monitor-internal.h | 1 -
accel/kvm/kvm-all.c | 2 +-
audio/audio-hmp-cmds.c | 83 +
block/monitor/block-hmp-cmds.c | 21 +
chardev/char-hmp-cmds.c | 220 +++
chardev/char.c | 20 +
hw/acpi/acpi-qmp-cmds.c | 30 +
hw/core/machine-hmp-cmds.c | 208 +++
hw/core/machine-qmp-cmds.c | 144 ++
hw/net/rocker/rocker-hmp-cmds.c | 316 ++++
hw/virtio/virtio-hmp-cmds.c | 321 ++++
migration/migration-hmp-cmds.c | 807 ++++++++++
migration/migration.c | 30 +
monitor/fds.c | 468 ++++++
monitor/hmp-cmds-target.c | 380 +++++
monitor/hmp-cmds.c | 2181 ++------------------------
monitor/hmp-target.c | 178 +++
monitor/hmp.c | 17 +-
monitor/misc.c | 1906 ----------------------
monitor/monitor.c | 30 +-
monitor/qmp-cmds-control.c | 1 -
monitor/qmp-cmds.c | 355 +----
net/net-hmp-cmds.c | 170 ++
net/net.c | 28 +-
qom/qom-hmp-cmds.c | 67 +
softmmu/qdev-monitor.c | 82 +
softmmu/runstate-hmp-cmds.c | 82 +
softmmu/tpm-hmp-cmds.c | 65 +
stats/stats-hmp-cmds.c | 247 +++
stats/stats-qmp-cmds.c | 162 ++
storage-daemon/qemu-storage-daemon.c | 4 +-
trace/trace-hmp-cmds.c | 148 ++
util/readline.c | 8 +
audio/meson.build | 1 +
chardev/meson.build | 6 +-
hmp-commands.hx | 4 +-
hw/acpi/meson.build | 1 +
hw/net/meson.build | 1 +
hw/virtio/meson.build | 1 +
migration/meson.build | 1 +
monitor/meson.build | 4 +-
net/meson.build | 1 +
softmmu/meson.build | 2 +
stats/meson.build | 1 +
trace/meson.build | 1 +
54 files changed, 4574 insertions(+), 4286 deletions(-)
rename include/{monitor => sysemu}/stats.h (100%)
create mode 100644 audio/audio-hmp-cmds.c
create mode 100644 chardev/char-hmp-cmds.c
create mode 100644 hw/acpi/acpi-qmp-cmds.c
create mode 100644 hw/net/rocker/rocker-hmp-cmds.c
create mode 100644 hw/virtio/virtio-hmp-cmds.c
create mode 100644 migration/migration-hmp-cmds.c
create mode 100644 monitor/fds.c
create mode 100644 monitor/hmp-cmds-target.c
create mode 100644 monitor/hmp-target.c
delete mode 100644 monitor/misc.c
create mode 100644 net/net-hmp-cmds.c
create mode 100644 softmmu/runstate-hmp-cmds.c
create mode 100644 softmmu/tpm-hmp-cmds.c
create mode 100644 stats/stats-hmp-cmds.c
create mode 100644 stats/stats-qmp-cmds.c
create mode 100644 trace/trace-hmp-cmds.c
create mode 100644 stats/meson.buildSignature · 1 line
2.39.0