Skip to content

hw/cxl: Passthrough HDM decoder emulation

Jonathan Cameron linux-cxl qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Rebase and pick up tags.
- State prereq patche sets more clearly.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/pci: Add pcie_count_ds_port() and pcie_find_port_first() helpershw/pci/pcie_port.c include/hw/pci/pcie_port.h+40 -00 replies
2/2hw/pxb-cxl: Support passthrough HDM Decoders unless overriddenhw/cxl/cxl-host.c hw/pci-bridge/pci_expander_bridge.c include/hw/cxl/cxl.h +2 more+61 -170 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchFan Ni
1/2
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] hw/cxl: Passthrough HDM decoder emulation

v2:
- Rebase and pick up tags.
- State prereq patche sets more clearly.

Mostly sending out again because some of the precursors have been updated and to fix a typo in a tag given on v1.

Until now, testing using CXL has relied up always using two root ports below a host bridge, to work around a current assumption in the Linux kernel support that, in the single root port case, the implementation will use the allowed passthrough decoder implementation choice. If that choice is made all accesses are routed from the host bridge to the single root port that is present. Effectively we have a pass through decoder (it is called that in the kernel driver).

This patch series implements that functionality and makes it the default See patch 2 for a discussion of why I think we can make this change without backwards compatibility issues (basically if it didn't work before who are we breaking by making it work?)

Whilst this limitation has been known since the initial QEMU patch postings / kernel CXL region support, Fan Ni ran into it recently reminding me that we should solve it.

Note that if you enable hdm_for_passthrough and use a configuration that would otherwise get a passthrough decoder, the linux kernel will currently fail to set it up correctly. That's a bug / missing feature in Linux not an issue with the emulation.

Based on series "[PATCH v4 00/10] hw/cxl: CXL emulation cleanups and minor fixes for upstream" Based on series "[PATCH v6 0/8] hw/cxl: RAS error emulation and injection"

Based on: Message-Id: [email protected] Based on: Message-Id: [email protected]

Jonathan Cameron (2):
hw/pci: Add pcie_count_ds_port() and pcie_find_port_first() helpers hw/pxb-cxl: Support passthrough HDM Decoders unless overridden

 hw/cxl/cxl-host.c                   | 31 ++++++++++++--------
 hw/pci-bridge/pci_expander_bridge.c | 44 +++++++++++++++++++++++++----
 hw/pci/pcie_port.c                  | 38 +++++++++++++++++++++++++
 include/hw/cxl/cxl.h                |  1 +
 include/hw/cxl/cxl_component.h      |  1 +
 include/hw/pci/pci_bridge.h         |  1 +
 include/hw/pci/pcie_port.h          |  2 ++
 7 files changed, 101 insertions(+), 17 deletions(-)
Signature · 1 line
2.37.2