block: Fix bdrv_open*() calls from coroutine context
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 4 repliesIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Emanuele Giuseppe Esposito | Hanna Czenczek |
|---|---|---|
| Series | R-b | R-b |
| 1/13 | ||
| 2/13 | ||
| 3/13 | ||
| 4/13 | ||
| 5/13 | ||
| 6/13 | ||
| 7/13 | ||
| 8/13 | ||
| 9/13 | ||
| 10/13 | ||
| 11/13 | ||
| 12/13 | ||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/13] block: Fix bdrv_open*() calls from coroutine context
bdrv_open*() must not be called from coroutine context, amongst others because it modifies the block graph. However, some functions - in particular all .bdrv_co_create* implementations of image formats - do call it from coroutine context. This is already wrong today, but when we add locking, it actually becomes visible.
This series adds no_co_wrapper functions, which are automatically generated wrappers that run in coroutine context and use a BH to call the wrapped function outside of coroutine context. It then uses these wrappers to fix the problematic bdrv_open*() calls.
Kevin Wolf (13):
block-coroutine-wrapper: Introduce no_co_wrapper
block: Create no_co_wrappers for open functions
luks: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
parallels: Fix .bdrv_co_create(_opts) to open images with
no_co_wrapper
qcow: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
qcow2: Fix open/create to open images with no_co_wrapper
qed: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
vdi: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
vhdx: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
vmdk: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
vpc: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
block: Fix bdrv_co_create_opts_simple() to open images with
no_co_wrapper
block: Assert non-coroutine context for bdrv_open_inherit()
include/block/block-common.h | 14 ++++ include/block/block-global-state.h | 35 ++++++--- include/sysemu/block-backend-global-state.h | 21 +++++- block.c | 17 ++--- block/crypto.c | 10 +-- block/parallels.c | 10 +-- block/qcow.c | 10 +-- block/qcow2.c | 43 +++++------ block/qed.c | 10 +-- block/vdi.c | 10 +-- block/vhdx.c | 10 +-- block/vmdk.c | 22 +++--- block/vpc.c | 10 +-- scripts/block-coroutine-wrapper.py | 83 ++++++++++++++++++--- block/meson.build | 1 + 15 files changed, 207 insertions(+), 99 deletions(-)
Signature · 1 line
2.38.1