Skip to content

tools/ocaml: Memory corruption fixes in bindings

Andrew Cooper xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tools/ocaml/libs: Don't declare stubs as taking voidtools/ocaml/libs/xb/xenbus_stubs.c tools/ocaml/libs/xc/xenctrl_stubs.c+4 -50 replies
2/7tools/ocaml/libs: Allocate the correct amount of memory for Abstract_tagtools/ocaml/libs/mmap/Makefile tools/ocaml/libs/mmap/xenmmap_stubs.c tools/ocaml/libs/xc/xenctrl_stubs.c+11 -20 replies
3/7tools/ocaml/evtchn: Don't reference Custom objects with the GC lock releasedtools/ocaml/libs/eventchn/xeneventchn_stubs.c+35 -250 replies
4/7tools/ocaml/evtchn: Misc cleanuptools/ocaml/libs/eventchn/xeneventchn_stubs.c+18 -270 replies
5/7tools/ocaml/xc: Fix binding for xc_domain_assign_device()tools/ocaml/libs/xc/xenctrl_stubs.c+5 -120 replies
6/7tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock releasedtools/ocaml/libs/xc/xenctrl_stubs.c+11 -120 replies
7/7tools/ocaml/xc: Don't reference Custom objects with the GC lock releasedtools/ocaml/libs/xc/xenctrl_stubs.c+251 -2030 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian Lindig
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] tools/ocaml: Memory corruption fixes in bindings

It turns out there have been some latent memory corruption bugs and other errors in the bindings since they were first introduced.

These were discovered after realising that we'd introduced other memory corruption bugs as part of the Ocaml 5 fixes, and in the case of the evtchn bindings, backported this as part of the oxenstored-lu fixes.

This series addresses all the memory corrupution issues we're aware of that can occur in an entirely well-formed program.

Deferred for now are the (hopefully latent) memory corruption errors which happen due to bad parameter passing, and a substantial pile of related cleanup.

Andrew Cooper (3):
tools/ocaml/libs: Allocate the correct amount of memory for Abstract_tag tools/ocaml/evtchn: Misc cleanup
tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock released

Edwin Török (4):
tools/ocaml/libs: Don't declare stubs as taking void tools/ocaml/evtchn: Don't reference Custom objects with the GC lock released tools/ocaml/xc: Fix binding for xc_domain_assign_device() tools/ocaml/xc: Don't reference Custom objects with the GC lock released

 tools/ocaml/libs/eventchn/xeneventchn_stubs.c |  89 ++---
 tools/ocaml/libs/mmap/Makefile                |   2 +
 tools/ocaml/libs/mmap/xenmmap_stubs.c         |   6 +-
 tools/ocaml/libs/xb/xenbus_stubs.c            |   5 +-
 tools/ocaml/libs/xc/xenctrl_stubs.c           | 494 ++++++++++++++------------
 5 files changed, 323 insertions(+), 273 deletions(-)
Signature · 1 line
2.11.0