Skip to content

Simplify ufshcd_execute_start_stop()

Bart Van Assche linux-scsi 3 versions – Applied

Status from this message: Applied to 6.3/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesApplied
  2. v23 patches 5 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Changed the type of scsi_exec_args.scmd_flags from unsigned int into int.
- Left out a WARN_ON_ONCE() statement from patch 2/3 that was removed by patch 3/3 anyway.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3scsi: core: Extend struct scsi_exec_argsdrivers/scsi/scsi_lib.c include/scsi/scsi_device.h+2 -00 replies
2/3scsi: ufs: Rely on the block layer for setting RQF_PMdrivers/ufs/core/ufshcd.c+1 -10 replies
3/3scsi: ufs: Simplify ufshcd_execute_start_stop()drivers/ufs/core/ufshcd.c+8 -271 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJohn GarryAsutosh Das
1/3R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Simplify ufshcd_execute_start_stop()

Hi Martin,

This patch series simplifies ufshcd_execute_start_stop() by using the new scsi_execute_cmd() function instead of open-coding it. Please consider this patch for the next merge window.

Thanks,

Bart.

Changes compared to v2:
- Changed the type of scsi_exec_args.scmd_flags from unsigned int into int.
- Left out a WARN_ON_ONCE() statement from patch 2/3 that was removed by patch 3/3 anyway.

Changes compared to v1:
- Addressed John's feedback that RQF_PM should always be set if BLK_MQ_REQ_PM is set.
- Added a third patch that makes RQF_PM to be set implicitly.

Bart Van Assche (3):
scsi: core: Extend struct scsi_exec_args
scsi: ufs: Rely on the block layer for setting RQF_PM
scsi: ufs: Simplify ufshcd_execute_start_stop()

 drivers/scsi/scsi_lib.c    |  1 +
 drivers/ufs/core/ufshcd.c  | 35 ++++++++---------------------------
 include/scsi/scsi_device.h |  1 +
 3 files changed, 10 insertions(+), 27 deletions(-)