Skip to content

Remove get_kernel_pages()

Ira Weiny linux-mm lkml op-tee 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20230203-get_kernel_pages-199342cfba79

Versions newest first · linked by author and title

  1. v2 Latest4 patches 22 repliesIn review
  2. v14 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- Al Viro: Avoid allocating the kiov.
- Sumit: Update cover letter to clarify the motivation behind removing get_kernel_pages()
- Link to v1: https://lore.kernel.org/r/20221002002326.946620-1-ira.weiny(a)intel.com

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4highmem: Enhance is_kmap_addr() to check kmap_local_page() mappingsinclude/linux/highmem-internal.h+4 -14 replies
2/4tee: Remove vmalloc page supportdrivers/tee/tee_shm.c+12 -243 replies
3/4tee: Remove call to get_kernel_pages()drivers/tee/tee_shm.c+8 -133 replies
4/4mm: Remove get_kernel_pages()include/linux/mm.h mm/swap.c+0 -324 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJens WiklanderJohn HubbardChristoph HellwigSumit GargAndrew Morton
1/4A-b
2/4R-b R-b R-b
3/4R-b R-b
4/4A-b R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] Remove get_kernel_pages()

Sumit,

I did not see a follow up on this series per your last email.[1] I'd like to move forward with getting rid of kmap_to_page(). So Hopefully this can land and you can build on this rather than the other way around?

All,

Al Viro found[2] that kmap_to_page() is broken. But not only is it broken, it presents confusion over how highmem should be used because kmap() and friends should not be used for 'long term' mappings.

get_kernel_pages() is a caller of kmap_to_page(). It only has one caller [shm_get_kernel_pages()] which does not need the functionality.

Alter shm_get_kernel_pages() to no longer call get_kernel_pages() and remove get_kernel_pages(). Along the way it was noted that shm_get_kernel_pages() does not have any need to support vmalloc'ed addresses either. Remove that functionality to clean up the logic.

This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses slip in later.

[1] https://lore.kernel.org/all/CAFA6WYMqEVDVW-ifoh-V9ni1zntYdes8adQKf2XXAUpqdaW53w(a)mail.gmail.com/
[2] https://lore.kernel.org/lkml/YzSSl1ItVlARDvG3(a)ZenIV

To: Sumit Garg <[email protected]>
To: Andrew Morton <[email protected]>

Cc "Al Viro" <[email protected]>
Cc "Christoph Hellwig" <[email protected]>
Cc linux-kernel(a)vger.kernel.org
Cc op-tee(a)lists.trustedfirmware.org
Cc linux-mm(a)kvack.org
Cc Jens Wiklander <[email protected]>
Cc "Fabio M. De Francesco" <[email protected]>

---
Changes in v2:
- Al Viro: Avoid allocating the kiov.
- Sumit: Update cover letter to clarify the motivation behind removing get_kernel_pages()
- Link to v1: https://lore.kernel.org/r/20221002002326.946620-1-ira.weiny(a)intel.com

---
Ira Weiny (4):
highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings
tee: Remove vmalloc page support
tee: Remove call to get_kernel_pages()
mm: Remove get_kernel_pages()

 drivers/tee/tee_shm.c            | 37 ++++++++++---------------------------
 include/linux/highmem-internal.h |  5 ++++-
 include/linux/mm.h               |  2 --
 mm/swap.c                        | 30 ------------------------------
 4 files changed, 14 insertions(+), 60 deletions(-)

---
base-commit: 0136d86b78522bbd5755f8194c97a987f0586ba5
change-id: 20230203-get_kernel_pages-199342cfba79

Best regards,

Signature · 1 line
Ira Weiny <[email protected]>