PCI: s390: Fix user-after-free and clean up
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 9 repliesIn review
- v1 posting 2/21 patch 9 repliesSuperseded
- v1 posting 1/21 patch 2 repliesSuperseded
Changes in v2 from the cover letter
- Added clean up patches inspired by Bjorn's questions
- Removed return at end of function returning void
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | PCI: s390: Fix use-after-free of PCI resources with per-function hotplugarch/ arch/ arch/ +2 more | +38 | 6 replies | |
| 2/4 | s390/pci: only add specific device in zpci_bus_scan_device()arch/ | +1 | 1 reply | |
| 3/4 | s390/pci: remove redundant pci_bus_add_devices() on new busarch/ | +0 | 1 reply | |
| 4/4 | s390/pci: clean up left over special treatment for function zeroarch/ | +3 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Bjorn Helgaas | Matthew Rosato |
|---|---|---|
| 1/4 | A-b | R-b |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] PCI: s390: Fix user-after-free and clean up
Hi Bjorn, Hi Lukas,
This is v2 of my fix for a use-after-free of PCI MMIO resources in the s390 PCI layer. As Bjorn found some redundant pci_bus_add_device() uses and function zero special treatment I've added 3 cleanup patches in addition to the fix itself. These are independent but in my opinion make it easier to see the struct zpci_dev interactions with the common PCI code. If you prefer I can of course split them off. As discussed this version still uses the pci_rescan_remove lock to allow backporting but I'll be looking into adding a more specific resource lock as a follow up.
Thanks,
Niklas
Changes since v1:
- Added clean up patches inspired by Bjorn's questions
- Removed return at end of function returning void
Niklas Schnelle (4):
PCI: s390: Fix use-after-free of PCI resources with per-function
hotplug
s390/pci: only add specific device in zpci_bus_scan_device() s390/pci: remove redundant pci_bus_add_devices() on new bus s390/pci: clean up left over special treatment for function zero
arch/s390/pci/pci.c | 39 +++++++++++++-------------------------- arch/s390/pci/pci_bus.c | 16 ++++++---------- arch/s390/pci/pci_bus.h | 3 +-- drivers/pci/bus.c | 21 +++++++++++++++++++++ include/linux/pci.h | 1 + 5 files changed, 42 insertions(+), 38 deletions(-)
Signature · 1 line
2.37.2