Skip to content

refactor file signing program

Shreenidhi Shedi linux-kbuild lkml 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest7 patches 7 repliesIn review
  2. v88 patches 0 repliesSuperseded
  3. v78 patches 10 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v6 posting 2/27 patches11 repliesSuperseded
v6 posting 1/20 of 7 patches0 repliesSuperseded
v5 posting 2/27 patches4 repliesSuperseded
v5 posting 1/27 patches0 repliesSuperseded
v46 patches9 repliesSuperseded
v36 patches8 repliesSuperseded
v26 patches0 repliesSuperseded
v14 patches2 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7sign-file: use getopt_long_only for parsing input argsscripts/sign-file.c+78 -191 reply
2/7sign-file: inntroduce few new flags to make argument processing easy.scripts/Makefile.modinst scripts/sign-file.c+48 -192 replies
3/7sign-file: move file signing logic to its own functionscripts/sign-file.c+54 -611 reply
4/7sign-file: add support to sign modules in bulkscripts/sign-file.c+27 -142 replies
5/7sign-file: improve help messagescripts/sign-file.c+41 -71 reply
6/7sign-file: use const with a global string constantscripts/sign-file.c+1 -10 replies
7/7sign-file: fix do while styling issuescripts/sign-file.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [PATCH v9 0/7] refactor file signing program

This patch series refactors the sign-file program.

Brief of changes in this patch series:

- Improve argument parsing logic.
- Add few more easy to remember arguments.
- Add support to sign bunch of modules at once.
- Improve the help message with examples.
- Few trivial checkpatch reported issue fixes.

Version 9 changes:
- Dropped kbuild related changes, thanks to Masahiro Yamada for all the inputs and advices.

Version 8 changes:
- Addressed comments from Masahiro Yamada
- Fix the bisect'ability error in patch 2.
- Fix missed out modules_sign_only issue.

Version 7 changes:
- Change Makefile.modinst and divide the tasks further
- Don't do everything from one place.
- This whole thing is done to facilitate bulk signing of modules
- Greg suggsted this idea here:
https://lore.kernel.org/all/2023060155-mustard-mating-32b7@gregkh/
- Thanks for the inputs Greg
- v7-0008-kbuild-modinst-do-modules_install-step-by-step.patch is fairly big and I'm sorry about it. I created all patches considering build stability in mind, so this can't be broken into pieces else in the intermediate commit build will break.

Version 6 changes:
- Fix commit messages as suggested by Greg and David.

Version 5 changes:
- Addressed review comments from David Howells.
- Fragmented the patches into further small units.
Link:
v4: https://lore.kernel.org/all/[email protected]/

Version 1 - Version 4 changes:
Did some back and forth changes. Getting familiar with patch submission process, nothing significant happened.

Links:
v1: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]

Shreenidhi Shedi (7):
sign-file: use getopt_long_only for parsing input args
sign-file: inntroduce few new flags to make argument processing easy.
sign-file: move file signing logic to its own function
sign-file: add support to sign modules in bulk
sign-file: improve help message
sign-file: use const with a global string constant
sign-file: fix do while styling issue

 scripts/Makefile.modinst |   4 +-
 scripts/sign-file.c      | 292 ++++++++++++++++++++++++++++-----------
 2 files changed, 212 insertions(+), 84 deletions(-)

--
2.41.0