Skip to content

pata_parport: protocol drivers fixes and cleanups

Ondrej Zary linux-block linux-ide lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/218 patches 1 replyIn review
  2. v4 posting 1/218 patches 1 replySuperseded
  3. v318 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v218 patches3 repliesSuperseded
v112 patches16 repliesSuperseded

Changes in v4 from the cover letter

- dropped whitespace changes from patch 12/18

Patches in v4 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18pata_parport: fix EPAT C7/C8 Kconfigdrivers/ata/pata_parport/epat.c+1 -10 replies
2/18pata_parport: probe all units automaticallydrivers/ata/pata_parport/pata_parport.c+2 -20 replies
3/18pata_parport: Remove pi_swab16 and pi_swab32drivers/ata/pata_parport/comm.c drivers/ata/pata_parport/kbic.c include/linux/pata_parport.h+10 -210 replies
4/18pata_parport: remove useless printks at module_init of bpck6drivers/ata/pata_parport/bpck6.c+0 -40 replies
5/18pata_parport: Introduce module_pata_parport_driver macrodrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +13 more+31 -1660 replies
6/18pata_parport: remove devtype from struct pi_adapterdrivers/ata/pata_parport/bpck.c include/linux/pata_parport.h+2 -50 replies
7/18pata_parport: remove device from struct pi_adapterdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +13 more+39 -490 replies
8/18pata_parport: remove typedef struct PIAdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +13 more+128 -1300 replies
9/18pata_parport: remove verbose parameter from log_adapter()drivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +14 more+23 -260 replies
10/18pata_parport: remove scratch parameter from log_adapter()drivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +14 more+22 -220 replies
11/18pata_parport: use dev_* instead of printkdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +12 more+48 -790 replies
12/18pata_parport: use print_hex_*drivers/ata/pata_parport/bpck.c+4 -180 replies
13/18pata_parport: simplify log_adapter prints, remove VERSION definesdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +12 more+32 -910 replies
14/18pata_parport: remove bpck6 verbose parameterdrivers/ata/pata_parport/bpck6.c+0 -50 replies
15/18pata_parport: remove verbose parameter from test_proto()drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/epat.c drivers/ata/pata_parport/epia.c +4 more+7 -70 replies
16/18pata_parport: remove scratch parameter from test_proto()drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/epat.c drivers/ata/pata_parport/epia.c +4 more+21 -180 replies
17/18pata_parport: remove obsolete changelogsdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +9 more+0 -830 replies
18/18pata_parport: move pata_parport.h to drivers/ata/pata_parportdrivers/ata/pata_parport/aten.c drivers/ata/pata_parport/bpck.c drivers/ata/pata_parport/bpck6.c +14 more+16 -310 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchSergey Shtylyov
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH RESEND v4 0/18] pata_parport: protocol drivers fixes and cleanups

This patch series fixes two bugs and cleans up pata_parport protocol drivers, making the code simpler with no changes in behavior (except logged messages).

---
Changes in v4:
- dropped whitespace changes from patch 12/18
Changes in v3:
- added missing reviewed-by tags
- added more detailed changelog:
- patches 04-05 are split from v1 patch 02/12
- patch 06: comment-out instead of if(1)
- patches 11-14 are split from v1 patch 08/12
Changes in v2:
- added two bugfixes (first two patches)
- addressed Sergey's comments (mostly split patches)

 drivers/ata/pata_parport/aten.c                            |  45 ++++----------
 drivers/ata/pata_parport/bpck.c                            |  86 ++++++++------------------
 drivers/ata/pata_parport/bpck6.c                           | 107 ++++++++-------------------------
 drivers/ata/pata_parport/comm.c                            |  52 +++++-----------
 drivers/ata/pata_parport/dstr.c                            |  45 ++++----------
 drivers/ata/pata_parport/epat.c                            |  48 ++++++---------
 drivers/ata/pata_parport/epia.c                            |  55 +++++------------
 drivers/ata/pata_parport/fit2.c                            |  37 ++++--------
 drivers/ata/pata_parport/fit3.c                            |  39 ++++--------
 drivers/ata/pata_parport/friq.c                            |  56 ++++++-----------
 drivers/ata/pata_parport/frpw.c                            |  71 ++++++----------------
 drivers/ata/pata_parport/kbic.c                            |  66 +++++++++-----------
 drivers/ata/pata_parport/ktti.c                            |  38 ++++--------
 drivers/ata/pata_parport/on20.c                            |  45 ++++----------
 drivers/ata/pata_parport/on26.c                            |  52 ++++------------
 drivers/ata/pata_parport/pata_parport.c                    |  31 +++++-----
 {include/linux => drivers/ata/pata_parport}/pata_parport.h |  41 ++++---------
 17 files changed, 271 insertions(+), 643 deletions(-)