Skip to content

leds: ledtrig-tty: add tty_led_mode xtension

Florian Eckert linux-leds lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest3 patches 2 repliesIn review
  2. v72 patches 9 repliesSuperseded
  3. v62 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v52 patches3 repliesSuperseded
v42 patches0 repliesSuperseded
v32 patches1 replySuperseded
v22 patches1 replySuperseded
v12 patches7 repliesSuperseded

Changes in v8 from the cover letter

Changes compared to the v7 patchset with
[email protected] are.

* Update 'Documentation/ABI/testing/sysfs-class-led-trigger-tty' with the suggested changes.
* Use a meaningfull name for the Rx/Tx enum.
* Do not use C++ comments style

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tty: new helper function tty_get_mgetdrivers/tty/tty_io.c include/linux/tty.h+23 -60 replies
2/3trigger: ledtrig-tty: add additional modesDocumentation/ABI/testing/sysfs-class-led-trigger-tty drivers/leds/trigger/ledtrig-tty.c+146 -150 replies
3/3ledtrig-tty: call correct brightness set functiondrivers/leds/trigger/ledtrig-tty.c+6 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/3] leds: ledtrig-tty: add tty_led_mode xtension

Hello,

here commes v8 of this series to add additional tty_led_modes.

v8:
Changes compared to the v7 patchset with
[email protected] are.

* Update 'Documentation/ABI/testing/sysfs-class-led-trigger-tty' with the suggested changes.
* Use a meaningfull name for the Rx/Tx enum.
* Do not use C++ comments style

Add a new patch 'ledtrig-tty-fix-brightness-set' to fix an issue with LEDs that are connected via GPIOs to the SOC with the device driver 'leds-gpio'. In my view, the wrong function is being used here. LEDs that do not need and do not have a delayed call do not work with the current implementation. Therefore, the 'led_set_brightness_nosleep' function must be used.

v7:
Changes compared to the v5 patchset with
[email protected] are.

Addressed review comments by Jiri Slaby are:

Thanks for the hint with the command 'make htmldocs SPHINXDIRS="admin-guide"'. Unfortunately, I did not know that. I have now verified it also in the browser. In my opinion, the list is now also displayed correctly in the documentation.

v6:
Changes compared to the v5 patchset with
[email protected] are.

Addressed review comments by kernel test robot are:

* fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9:
WARNING: Unexpected indentation.
* fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9:
WARNING: Block quote ends without a blank line; unexpected unindent.

Thanks to Jiri Slaby, who gave me the crucial hint of what I need to fix, to possibly make the 'Kernel test robot' happy.

v5:
Changes compared to the v4 patchset with
[email protected] are.

Sorry for the inconvenience, but I sent the wrong patch for ledtrig-tty.c in v4. The v5 patchset now includes all the changes I specified in the v4 patchset.

v4:
Changes compared to the v3 patchset with
[email protected] are.

Addressed review comments by Jiri Slaby are:

ledtrig-tty.c:
- Do not use __TTY_LED_MAX pattern us instead __TTY_LED_LAST = TTY_LED_RNG
- Move declartion and assignment into one singel line
- Use __TTY_LED_LAST pattern, to simplify tty_mode_show and tty_mode_store handling

v3:
Changes compared to the v2 patchset with
[email protected] are.

Addressed review comments by Greg K-H are:

tty.h:
- Fix first comment line and remark -%ENOTTY for the new function 'tty_get_mget' to make a proper kernel doc.
- Add the return value -%ENOTTY again, I thought it was no longer needed.

v2:
Changes compared to the initial patchset with
[email protected] are.

Addressed review comments by Jiri Slaby are:

tty.h:
- Fix compilation error because of wrong rebaseing
- Remove empty lines
- Use new 'tty_get_mget' in 'tty_tiocmget'

ledtrig-tty.c:
- Update commit description
- Use enum for tty_led_mod in struct ledtrig_tty_date
- Rename sysfs file from 'mode' to 'tty_led_mode'
- Change tty_led_mode show function to use loop instead of switch/case
- Change tty_led_mode store function to use loop instead of switch/case
- Check return value of function tty_get_mget

Florian Eckert (3):
tty: new helper function tty_get_mget
trigger: ledtrig-tty: add additional modes
ledtrig-tty: call correct brightness set function

 .../ABI/testing/sysfs-class-led-trigger-tty   |  18 +++
 drivers/leds/trigger/ledtrig-tty.c            | 145 ++++++++++++++++--
 drivers/tty/tty_io.c                          |  28 +++-
 include/linux/tty.h                           |   1 +
 4 files changed, 171 insertions(+), 21 deletions(-)
Signature · 1 line
2.30.2