Skip to content

hw/timer/i8254: Un-inline and simplify IRQs

Philippe Mathieu-Daudé kvm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/timer/hpet: Include missing 'hw/qdev-properties.h' headerhw/timer/hpet.c+1 -01 reply
2/5hw/timer/i8254: Factor i8254_pit_create() out and documenthw/timer/i8254.c include/hw/timer/i8254.h+29 -111 reply
3/5hw/i386/pc: Un-inline i8254_pit_init()hw/i386/pc.c include/hw/timer/i8254.h+7 -81 reply
4/5hw/timer/i8254: Really inline i8254_pit_init()hw/i386/microvm.c hw/isa/i82378.c hw/isa/piix4.c +3 more+6 -131 reply
5/5hw/i386/kvm: Factor i8254_pit_create_try_kvm() outhw/i386/kvm/i8254.c hw/i386/microvm.c hw/i386/pc.c +2 more+33 -261 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard HendersonMichael S. Tsirkin
SeriesA-b
1/5A-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs

i8254_pit_init() uses a odd pattern of "use this IRQ output line if non-NULL, otherwise use the ISA IRQ #number as output".

Rework as simply "Use this IRQ output".

Un-inline/rename/document functions.

Based-on: <[email protected]>
"hw/ide: Untangle ISA/PCI abuses of ide_init_ioport" v2
https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (5):
hw/timer/hpet: Include missing 'hw/qdev-properties.h' header hw/timer/i8254: Factor i8254_pit_create() out and document hw/i386/pc: Un-inline i8254_pit_init() hw/timer/i8254: Really inline i8254_pit_init() hw/i386/kvm: Factor i8254_pit_create_try_kvm() out

 hw/i386/kvm/i8254.c        | 18 ++++++++++++++
 hw/i386/microvm.c          |  6 +----
 hw/i386/pc.c               | 15 +++++-------
 hw/isa/i82378.c            |  2 +-
 hw/isa/piix4.c             |  4 ++--
 hw/isa/vt82c686.c          |  2 +-
 hw/mips/jazz.c             |  2 +-
 hw/timer/hpet.c            |  1 +
 hw/timer/i8254.c           | 16 +++++++++++++
 include/hw/timer/i8254.h   | 48 +++++++++++++-------------------------
 target/i386/kvm/kvm-stub.c |  6 +++++
 11 files changed, 69 insertions(+), 51 deletions(-)
Signature · 1 line
2.38.1