Skip to content

Assorted MOCS updates

Matt Roper intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 4 repliesIn review
  2. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Add a sanity check for uninitialized info->unused_entries_index
- Tweak some commit messages
- Don't overallocate GuC regset for platforms that don't need Wa_1607983814.
- For platforms that do need Wa_1607983814, only add the LNCF MOCS registers to the render engine's save/restore list.
- Drop HAS_RENDER_L3CC flag.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/xe/mocs: Drop unwanted TGL tabledrivers/gpu/drm/xe/xe_mocs.c+0 -460 replies
2/7drm/xe/mocs: Add missing RKL handlingdrivers/gpu/drm/xe/xe_mocs.c+1 -00 replies
3/7drm/xe/mocs: Drop xe_mocs_info_indexdrivers/gpu/drm/xe/xe_mocs.c+12 -280 replies
4/7drm/xe/mocs: Drop duplicate assignment of uc_indexdrivers/gpu/drm/xe/xe_mocs.c+0 -10 replies
5/7drm/xe/mocs: add MTL mocsdrivers/gpu/drm/xe/xe_mocs.c+65 -40 replies
6/7drm/xe/mocs: LNCF MOCS settings only need to be restored on pre-Xe_HPdrivers/gpu/drm/xe/xe_execlist.c drivers/gpu/drm/xe/xe_guc_ads.c drivers/gpu/drm/xe/xe_guc_submit.c +2 more+17 -203 replies
7/7drm/xe/mocs: Drop HAS_RENDER_L3CC flagdrivers/gpu/drm/xe/xe_mocs.c+4 -41 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchLucas De Marchi
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-xe] [PATCH v2 0/7] Assorted MOCS updates

The Xe MOCS code is heavily modelled after the equivalent i915 code, but there are a few items that are not appropriate for the Xe driver. Philippe's patch to add the MTL-specific table is also included.

As a follow-up, I'd like to rework Xe's MOCS to just use the xe_reg_sr framework. But that's a bit more invasive, so I'll save that for a future series.

v2:
- Add a sanity check for uninitialized info->unused_entries_index
- Tweak some commit messages
- Don't overallocate GuC regset for platforms that don't need Wa_1607983814.
- For platforms that do need Wa_1607983814, only add the LNCF MOCS registers to the render engine's save/restore list.
- Drop HAS_RENDER_L3CC flag.

Cc Lucas De Marchi <[email protected]>

Matt Roper (6):
drm/xe/mocs: Drop unwanted TGL table
drm/xe/mocs: Add missing RKL handling
drm/xe/mocs: Drop xe_mocs_info_index
drm/xe/mocs: Drop duplicate assignment of uc_index drm/xe/mocs: LNCF MOCS settings only need to be restored on pre-Xe_HP drm/xe/mocs: Drop HAS_RENDER_L3CC flag

Philippe Lecluse (1):
drm/xe/mocs: add MTL mocs

 drivers/gpu/drm/xe/xe_execlist.c   |   2 +-
 drivers/gpu/drm/xe/xe_guc_ads.c    |  20 +++-
 drivers/gpu/drm/xe/xe_guc_submit.c |   1 -
 drivers/gpu/drm/xe/xe_mocs.c       | 178 +++++++++++++----------------
 drivers/gpu/drm/xe/xe_mocs.h       |   1 -
 5 files changed, 99 insertions(+), 103 deletions(-)
Signature · 1 line
2.39.1