Skip to content

Fix IGT runner error logic when listing subtests

Mauro Carvalho Chehab igt-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1runner/job_list: return error on crashes while running --list-subtestsrunner/job_list.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/1] Fix IGT runner error logic when listing subtests

From: Mauro Carvalho Chehab <[email protected]>

Patches may end breaking --list-subtests if they, for instance, have a pattern like:

	igt_fixture
		fd = drm_open_driver(DRIVER);
	...
	do_something(fd);

	igt_subtest("foo")
		...
	igt_subtest("bar")
		...

As any usage of (fd) will cause a crash. As result, currently IGT will produce stderror outbut, but will keep executing, producing a wrong testlist, as "foo" and "bar" won't be listed.

That will also break scripts that would depend on a reliable testlist.

So, return an error on such cases.

Mauro Carvalho Chehab (1):
runner/job_list: return error on crashes while running --list-subtests

 runner/job_list.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.39.0