Skip to content

arch/*/io.h: remove ioremap_uc in some architectures

Baoquan He dri-devel linux-alpha linux-arch linux-fbdev linux-hexagon linux-m68k linux-mips linux-mm linux-parisc linux-sh linuxppc-dev lkml sparclinux 5 versions – Applied

Status from this message: applied to fbdev git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 9 repliesApplied
  2. v44 patches 15 repliesSuperseded
  3. v32 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches8 repliesSuperseded
v1 RFC2 patches2 repliesSuperseded

Changes in v5 from the cover letter

- In v4, Thomas reported that adding <asm-generic/io.h> including into mips always cause crash on his malta qemu. Finally, Jiaxun stood up to take over the patch 2/4 and make it work. This patchset collects Jiaxun's patch v5 and add Arnd's tag. Thanks to Jiaxun.
- Meanwhile, the old patch 4/4 need be adjusted because Jiaxun has done some removal of duplicated codes in <asm/io.h>.
- Add reviewers' tags from v4.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/4video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64drivers/video/fbdev/aty/atyfb_base.c+4 -01 reply
2/4mips: add <asm-generic/io.h> includingarch/mips/include/asm/io.h arch/mips/include/asm/mmiowb.h arch/mips/include/asm/smp-ops.h +3 more+75 -351 reply
3/4arch/*/io.h: remove ioremap_uc in some architecturesDocumentation/driver-api/device-io.rst arch/alpha/include/asm/io.h arch/hexagon/include/asm/io.h +6 more+5 -163 replies
4/4mips: io: remove duplicated codesarch/mips/include/asm/io.h+5 -232 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchGeert UytterhoevenMichael EllermanHelge DellerLuis ChamberlainArnd BergmannThomas BogendoerferJohn Paul Adrian GlaubitzJiaxun Yang
SeriesT-b
1/4R-b
2/4R-b A-b
3/4A-b A-b A-b A-b A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures

This patchset tries to remove ioremap_uc() in the current architectures except of x86 and ia64. They will use the default ioremap_uc version in <asm-generic/io.h> which returns NULL. Anyone who wants to add new invocation of ioremap_uc(), please consider using ioremap() instead or adding a new ARCH specific ioremap_uc(), or refer to the callsite in drivers/video/fbdev/aty/atyfb_base.c.

This change won't cuase breakage to the current kernel because in the only ioremap_uc callsite, an adjustment is made to eliminate impact in patch 1 of this series.

To get rid of all of them other than x86 and ia64, add asm-generic/io.h to asm/io.h of mips ARCH. With this adding, we can get rid of the ioremap_uc() in mips too. This is done in patch 2. And a followup patch 4 is added to remove duplicated code according to Arnd's suggestion.

Test:
=====
Except of Jiaxun's efficient testing on patch 2/4, I also did cross compiling of this series on mips64, building passed.

History:
=======
v4->v5:
- In v4, Thomas reported that adding <asm-generic/io.h> including into mips always cause crash on his malta qemu. Finally, Jiaxun stood up to take over the patch 2/4 and make it work. This patchset collects Jiaxun's patch v5 and add Arnd's tag. Thanks to Jiaxun.
- Meanwhile, the old patch 4/4 need be adjusted because Jiaxun has done some removal of duplicated codes in <asm/io.h>.
- Add reviewers' tags from v4.
v3->v4:
- Add patch 1 to adjust code in the only ioremap_uc() callsite so that later removing ioremap_uc() won't cause breakage.
- Update log and document writing in patch 3.
- Add followup patch 4 to clean up duplicated code in asm/io.h of MIPS.
v2->v3:
- In patch 1, move those macro definition of functio near its function declaration according to Arnd's suggestion. And remove the unneeded change in asm/mmiowb.h introduced in old version.
- In patch 2, clean up and rewrite the messy document related to ioremap_uc() in Documentation/driver-api/device-io.rst.
v1->v2:
- Update log of patch 2, and document related to ioremap_uc() according to Geert's comment.
- Add Geert's Acked-by.

Arnd Bergmann (1):
video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

Baoquan He (2):
arch/*/io.h: remove ioremap_uc in some architectures
mips: io: remove duplicated codes

Jiaxun Yang (1):
mips: add <asm-generic/io.h> including

 Documentation/driver-api/device-io.rst |   9 +-
 arch/alpha/include/asm/io.h            |   1 -
 arch/hexagon/include/asm/io.h          |   3 -
 arch/m68k/include/asm/kmap.h           |   1 -
 arch/mips/include/asm/io.h             | 123 +++++++++++++++----------
 arch/mips/include/asm/mmiowb.h         |   4 +-
 arch/mips/include/asm/smp-ops.h        |   2 -
 arch/mips/include/asm/smp.h            |   4 +-
 arch/mips/kernel/setup.c               |   1 +
 arch/mips/pci/pci-ip27.c               |   3 +
 arch/parisc/include/asm/io.h           |   2 -
 arch/powerpc/include/asm/io.h          |   1 -
 arch/sh/include/asm/io.h               |   2 -
 arch/sparc/include/asm/io_64.h         |   1 -
 drivers/video/fbdev/aty/atyfb_base.c   |   4 +
 15 files changed, 88 insertions(+), 73 deletions(-)
Signature · 1 line
2.41.0